-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm cairo integration #101
base: main
Are you sure you want to change the base?
Wasm cairo integration #101
Conversation
Can you review this PR, sir? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. I've been testing it and is really useful. Thanks you!
Just a couple of comments:
- We should, instead of having the binary commited we should add an step in the deployment that runs the compilation (we could do that if you want).
- Saw that you are using the version 2.0.0-rc2 of the compiler. Can you upgrade to latest?
- Also, for programs it works awesome. But with contracts it tries anyways to run the
main
entrypoint. Can you change that? Basically changing the compiler for contracts, and not running any entrypoint, just check if it compiles.
Really great job 🚀
Yes, let me make a script for this.
It is Compiler v2.0.1 I think. I will update it to 2.0.2.
Surely we can! It already has the function for this proposal. And all we need is just sth. like "Compiled success." or "Compiled failed." in the result dialog? BTW: Can you tell me how to set up github pages for |
Yes! That would be amazing.
I'm hooking you up with someone that can answer this. He should be answering soon. |
Hey there! |
Thanks for the reply @klaus993 ! In the local machine, it works perfectly. In the |
Because most of the codes in "Cairo by Example" are pure Cairo codes, adding an online playground for Cairo makes some sense.
Of course, this playground used https://github.com/lambdaclass/cairo-vm.
You can see how it works.
or see this video.