Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove static lifetime for name str parameter requirement for constant getter #1523

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix/get_constant_from_var_name

6b22b68
Select commit
Loading
Failed to load commit list.
Open

fix: remove static lifetime for name str parameter requirement for constant getter #1523

Merge branch 'main' into fix/get_constant_from_var_name
6b22b68
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 9, 2024 in 0s

97.11% (+2.34%) compared to f47f760

View this Pull Request on Codecov

97.11% (+2.34%) compared to f47f760

Details

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.11%. Comparing base (f47f760) to head (6b22b68).

❗ Current head 6b22b68 differs from pull request most recent head 97bb7df. Consider uploading reports for the commit 97bb7df to get more accurate results

Files Patch % Lines
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 71.42% 4 Missing ⚠️
...int_processor/builtin_hint_processor/math_utils.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   94.76%   97.11%   +2.34%     
==========================================
  Files         101       91      -10     
  Lines       38826    37248    -1578     
==========================================
- Hits        36795    36172     -623     
+ Misses       2031     1076     -955     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.