Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily link the artifact diffs #1066

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix daily link the artifact diffs #1066

merged 2 commits into from
Jan 28, 2025

Conversation

FrancoGiachetta
Copy link
Contributor

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (7d8871c) to head (5c24fcd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files         108      108           
  Lines       29557    29557           
=======================================
  Hits        23884    23884           
  Misses       5673     5673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.873 ± 0.025 3.832 3.903 1.02 ± 0.01
base dict_insert.cairo (AOT) 3.810 ± 0.037 3.765 3.886 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 3.897 ± 0.060 3.837 3.998 1.02 ± 0.02
head dict_insert.cairo (AOT) 3.814 ± 0.043 3.766 3.889 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 3.791 ± 0.043 3.718 3.872 1.03 ± 0.01
base dict_snapshot.cairo (AOT) 3.685 ± 0.024 3.641 3.717 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 3.827 ± 0.053 3.732 3.900 1.04 ± 0.02
head dict_snapshot.cairo (AOT) 3.697 ± 0.041 3.651 3.776 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.091 ± 0.041 4.049 4.166 1.00 ± 0.01
base factorial_2M.cairo (AOT) 4.072 ± 0.034 4.036 4.129 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 4.151 ± 0.039 4.101 4.213 1.01 ± 0.02
head factorial_2M.cairo (AOT) 4.095 ± 0.048 4.043 4.178 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.596 ± 0.025 3.571 3.657 1.01 ± 0.01
base fib_2M.cairo (AOT) 3.563 ± 0.021 3.533 3.586 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 3.646 ± 0.019 3.622 3.687 1.00
head fib_2M.cairo (AOT) 3.707 ± 0.067 3.602 3.813 1.02 ± 0.02

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.787 ± 0.022 3.754 3.833 1.03 ± 0.01
base linear_search.cairo (AOT) 3.673 ± 0.026 3.634 3.723 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 3.865 ± 0.037 3.821 3.936 1.02 ± 0.02
head linear_search.cairo (AOT) 3.786 ± 0.061 3.680 3.877 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.890 ± 0.021 3.869 3.930 1.04 ± 0.01
base logistic_map.cairo (AOT) 3.723 ± 0.022 3.694 3.758 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.993 ± 0.037 3.928 4.044 1.04 ± 0.02
head logistic_map.cairo (AOT) 3.839 ± 0.051 3.751 3.923 1.00

Copy link

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 21.032 ± 0.062 20.918 21.131 5.64 ± 0.02
cairo-native (embedded AOT) 3.731 ± 0.010 3.715 3.746 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.800 ± 0.020 3.778 3.843 1.02 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.737 ± 0.033 5.695 5.810 1.59 ± 0.01
cairo-native (embedded AOT) 3.611 ± 0.025 3.571 3.661 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.700 ± 0.027 3.667 3.763 1.02 ± 0.01

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.479 ± 0.166 14.141 14.641 3.61 ± 0.04
cairo-native (embedded AOT) 4.007 ± 0.019 3.981 4.038 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 4.031 ± 0.025 3.992 4.079 1.01 ± 0.01

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.470 ± 0.246 14.322 15.157 4.10 ± 0.07
cairo-native (embedded AOT) 3.531 ± 0.022 3.497 3.566 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.579 ± 0.022 3.541 3.614 1.01 ± 0.01

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.764 ± 0.027 5.725 5.808 1.58 ± 0.02
cairo-native (embedded AOT) 3.659 ± 0.043 3.612 3.741 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.752 ± 0.023 3.712 3.777 1.03 ± 0.01

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.672 ± 0.032 5.629 5.733 1.53 ± 0.02
cairo-native (embedded AOT) 3.705 ± 0.037 3.657 3.784 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.846 ± 0.028 3.821 3.895 1.04 ± 0.01

@azteca1998 azteca1998 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit bcc2a38 Jan 28, 2025
28 checks passed
@azteca1998 azteca1998 deleted the fix-ci-artifact branch January 28, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants