Simplify divisor interpolation and commitment in EVM final verification #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86aa70e.
* G2 Point deserialization support for the EVM verifier (#120) * Up anvil's block gas limit * Fixed verify script * Negate quotient commitment * Fix trusted setup length * Added Fq2 sqrt operation (an others necessary) * Fix fq2 sqrt typo * Added comments to the fq2 sqrt algorithm * Added fq2 sqrt test * Fix FQ1EulerCriterion * Fix FQ2Sqrt test * Add import * Added G2 decompression function * Formatting * Added test * Fixed G2Deserialize * Changed values order of deser test * Remove else case * Fixed deserializatio function * Added messagepack g2 deserialization functions * Update eth_verifier/lib/bn254/BN256G2.sol Co-authored-by: Pablo Deymonnaz <[email protected]> * Update eth_verifier/lib/bn254/BN256G2.sol Co-authored-by: Pablo Deymonnaz <[email protected]> * Update eth_verifier/script/Verify.s.sol Co-authored-by: Pablo Deymonnaz <[email protected]> * Fix flag mask in G2 ppint deser --------- Co-authored-by: Pablo Deymonnaz <[email protected]> * Escape char * WIP debugging URS deserialization * Fix urs test * Fix G2 deserialize y sign * Fixed final verification with some corners cut * Add comment and return verify result * Remove evaluation point require * Update eth_verifier/src/Verifier.sol * Update eth_verifier/src/Verifier.sol * Delete unused file * Re-enable verify test * Refactor tests --------- Co-authored-by: Pablo Deymonnaz <[email protected]>
pablodeymo
previously approved these changes
Jan 29, 2024
pablodeymo
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.