Rename `Declare` to `DeclareDeprecated` & `DeclareV2` to `Declare` #1220

fmoletta · 2024-02-02T16:35:06Z

Closes #1208
Based on #1210 for convenience

…pdate-block-context

…ename-declare

codecov-commenter · 2024-02-05T16:29:06Z

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (8f9b552) 88.97% compared to head (62b19c2) 88.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   88.97%   88.96%   -0.02%     
==========================================
  Files          52       52              
  Lines       15604    15588      -16     
==========================================
- Hits        13884    13868      -16     
  Misses       1720     1720

Files	Coverage Δ
src/core/transaction_hash/deprecated.rs	`99.63% <100.00%> (ø)`
src/lib.rs	`98.23% <100.00%> (ø)`
src/transaction/error.rs	`75.00% <ø> (ø)`
src/core/transaction_hash/current.rs	`88.74% <0.00%> (ø)`
src/core/transaction_hash/mod.rs	`60.33% <66.66%> (ø)`
src/transaction/mod.rs	`50.54% <36.36%> (ø)`
src/transaction/declare.rs	`88.87% <86.90%> (-2.50%)`	⬇️
src/transaction/declare_deprecated.rs	`91.36% <91.36%> (ø)`

... and 1 file with indirect coverage changes

cli/src/main.rs

src/transaction/declare.rs

juanbono

See comments

…ename-declare

pefontana

Nice one!

…ename-declare

fmoletta added 30 commits January 19, 2024 15:19

Add GasPricess & FeeTokenAddresses structs

d0b2590

Update code

6327d7a

Merge branch 'main' of github.com:lambdaclass/starknet_in_rust into u…

3ea4172

…pdate-block-context

RpcStateReader::get_gas_price fetch both

e24dacd

Update code

5a4d984

Clippy

c1d4bd0

Fix comment

81a61f2

Add VersionSpecificAccountTxFields struct

8d6168d

Integrate into TransactionExecutionContext

badc6a5

Replace max_fee field with account_tx_fields for InvokeFunction tx

2bb0091

Check tx account fields version when creating Invoke tx

93d0d61

Replace max_fee field with account_tx_fields for DeclareV3 tx

bcaab19

Replace max_fee field with account_tx_fields for DeployAccount tx

7f44d13

Update get_transaction_context for Txs not affected by this change

e7de24d

Fixes

444e288

Fixes

a832b62

Fixes

d08c64a

Fix handling of ignore_max_fee

9815fa1

Improve placeholder method

5bb3c5f

Handle TODOs

127da88

Implement get_onchain_data_cost

0099b22

Refactor

a6940c4

Generalize fn

8ae7451

Start implementing check_fee_bounds

791d45e

Finish implementing check_fee_bounds

d2aa130

Replace old code

f217d86

Fixes

c16c449

Implement FeeType for VersionSpecificAccountTxFields

49c0830

Update other txs

f7b7400

Clippy

5c265b1

fmoletta added the 0.13 label Feb 2, 2024

Base automatically changed from map-sn-api-ro-sir-structs to main February 2, 2024 21:28

Merge branch 'main' of github.com:lambdaclass/starknet_in_rust into r…

37994e8

…ename-declare

juanbono reviewed Feb 5, 2024

View reviewed changes

cli/src/main.rs Outdated Show resolved Hide resolved

juanbono reviewed Feb 5, 2024

View reviewed changes

src/transaction/declare.rs Outdated Show resolved Hide resolved

juanbono reviewed Feb 5, 2024

View reviewed changes

src/transaction/declare.rs Outdated Show resolved Hide resolved

juanbono reviewed Feb 5, 2024

View reviewed changes

src/transaction/declare.rs Outdated Show resolved Hide resolved

juanbono suggested changes Feb 5, 2024

View reviewed changes

fmoletta added 2 commits February 5, 2024 18:46

Fix merge

70fa0d8

Remove internal from variable names in tests

79626de

fmoletta requested a review from juanbono February 5, 2024 21:52

Fmt + fix typo

3fb91e9

juanbono previously approved these changes Feb 5, 2024

View reviewed changes

fmoletta and others added 3 commits February 7, 2024 15:58

Merge branch 'main' into rename-declare

a735a5e

Merge branch 'main' into rename-declare

d18c636

Merge branch 'main' of github.com:lambdaclass/starknet_in_rust into r…

1f6b6d6

…ename-declare

fmoletta dismissed juanbono’s stale review via 1f6b6d6 February 7, 2024 21:08

fmt

62b19c2

pefontana previously approved these changes Feb 7, 2024

View reviewed changes

juanbono previously approved these changes Feb 8, 2024

View reviewed changes

Merge branch 'main' of github.com:lambdaclass/starknet_in_rust into r…

09794d9

…ename-declare

fmoletta dismissed stale reviews from juanbono and pefontana via 09794d9 February 8, 2024 13:40

juanbono approved these changes Feb 8, 2024

View reviewed changes

pefontana approved these changes Feb 8, 2024

View reviewed changes

pefontana added this pull request to the merge queue Feb 8, 2024

Merged via the queue into main with commit 05e3bb9 Feb 8, 2024
7 checks passed

pefontana deleted the rename-declare branch February 8, 2024 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `Declare` to `DeclareDeprecated` & `DeclareV2` to `Declare` #1220

Rename `Declare` to `DeclareDeprecated` & `DeclareV2` to `Declare` #1220

fmoletta commented Feb 2, 2024 •

edited

Loading

codecov-commenter commented Feb 5, 2024 •

edited

Loading

juanbono left a comment

pefontana left a comment

Rename Declare to DeclareDeprecated & DeclareV2 to Declare #1220

Rename Declare to DeclareDeprecated & DeclareV2 to Declare #1220

Conversation

fmoletta commented Feb 2, 2024 • edited Loading

codecov-commenter commented Feb 5, 2024 • edited Loading

Codecov Report

juanbono left a comment

Choose a reason for hiding this comment

pefontana left a comment

Choose a reason for hiding this comment

Rename `Declare` to `DeclareDeprecated` & `DeclareV2` to `Declare` #1220

Rename `Declare` to `DeclareDeprecated` & `DeclareV2` to `Declare` #1220

fmoletta commented Feb 2, 2024 •

edited

Loading

codecov-commenter commented Feb 5, 2024 •

edited

Loading