Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to php 8.3 and remove php 8.0 as a dependency. #25

Open
wants to merge 7 commits into
base: 1.7.x
Choose a base branch
from

Conversation

datasage
Copy link

Q A
Documentation no
Bugfix yes/no
BC Break yes
New Feature no
RFC no
QA no

Description

Add PHP 8.3 as a supported version and removed php 8.0 as a supported version.

Included is an update to phpunit 10.x and psalm 5.x.

All the required packages were updated to the minimum version that matched the php version requirments

@InstantlyMoist
Copy link

merge and release
merge and release
merge and release

src/ApiProblem.php Outdated Show resolved Hide resolved
src/ApiProblem.php Outdated Show resolved Hide resolved
src/ApiProblem.php Outdated Show resolved Hide resolved
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert ApiProblem change as bc break

@datasage
Copy link
Author

@samsonasik Removed most of the type hints for now. Understand the concern about compatibility.

src/ApiProblem.php Outdated Show resolved Hide resolved
@kersysgediminas
Copy link

@samsonasik All requested changes were made, please review.

@svycka
Copy link
Contributor

svycka commented May 13, 2024

Hello @datasage, do you plan to update this PR? Do you need any help?

Signed-off-by: Dan Johansson <[email protected]>
@datasage
Copy link
Author

All CI checks are passing now

Signed-off-by: Dan Johansson <[email protected]>
@samsonasik
Copy link
Member

composer.lock need to be regenerated

Signed-off-by: Dan Johansson <[email protected]>
@marc-mabe
Copy link

Any chance this could be merged? It's the last blocker for upgrading to PHP 8.3 for me

@InstantlyMoist
Copy link

Any chance this could be merged? It's the last blocker for upgrading to PHP 8.3 for me

Waiting for it too, I did notice this though: https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2024-05-06-TSC-Minutes.md#api-tools-related-proposed-by-dotkernel-organisation

As far as I understand it, the Laminas API tools might get deprecated

@marc-mabe
Copy link

As far as I understand it, the Laminas API tools might get deprecated

If it's deprecated it's deprecated - no question - but right now it's not

@Xerkus
Copy link
Member

Xerkus commented Jul 15, 2024

API Tools are currently on security only maintenance mode and PHP 8.3 support is not planned.

I expect API Tools to be entirely discontinued with Dotkernel API as a replacement based on Mezzio: https://getlaminas.org/blog/2024-07-02-dotkernel-a-replacement-for-laminas-api-tools.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants