-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to php 8.3 and remove php 8.0 as a dependency. #25
base: 1.7.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Dan Johansson <[email protected]>
merge and release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert ApiProblem
change as bc break
Signed-off-by: Dan Johansson <[email protected]>
@samsonasik Removed most of the type hints for now. Understand the concern about compatibility. |
Signed-off-by: Dan Johansson <[email protected]>
Signed-off-by: Dan Johansson <[email protected]>
@samsonasik All requested changes were made, please review. |
Hello @datasage, do you plan to update this PR? Do you need any help? |
Signed-off-by: Dan Johansson <[email protected]>
All CI checks are passing now |
Signed-off-by: Dan Johansson <[email protected]>
composer.lock need to be regenerated |
Signed-off-by: Dan Johansson <[email protected]>
Any chance this could be merged? It's the last blocker for upgrading to PHP 8.3 for me |
Waiting for it too, I did notice this though: https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2024-05-06-TSC-Minutes.md#api-tools-related-proposed-by-dotkernel-organisation As far as I understand it, the Laminas API tools might get deprecated |
If it's deprecated it's deprecated - no question - but right now it's not |
API Tools are currently on security only maintenance mode and PHP 8.3 support is not planned. I expect API Tools to be entirely discontinued with Dotkernel API as a replacement based on Mezzio: https://getlaminas.org/blog/2024-07-02-dotkernel-a-replacement-for-laminas-api-tools.html |
Description
Add PHP 8.3 as a supported version and removed php 8.0 as a supported version.
Included is an update to phpunit 10.x and psalm 5.x.
All the required packages were updated to the minimum version that matched the php version requirments