Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support range for PHP #25

Open
wants to merge 4 commits into
base: 1.10.x
Choose a base branch
from

Conversation

juicylime
Copy link

@juicylime juicylime commented Nov 3, 2022

Signed-off-by: Aman Ahlwat [email protected]

Q A

| New Feature | yes

Description

Extending the support range for PHP to support ~8.0

Fixes #24

Signed-off-by: Aman Ahlwat <[email protected]>
composer.json Outdated Show resolved Hide resolved
@Ocramius Ocramius added the Enhancement New feature or request label Nov 3, 2022
@Ocramius Ocramius added this to the 1.10.0 milestone Nov 3, 2022
@Ocramius
Copy link
Member

Ocramius commented Nov 3, 2022

Hmm, I think this error is because CI didn't run in a while, and composer/composer:2.3.x broke BC here.

config.allow-plugins is missing here: a local composer install will highlight that.

@Ocramius
Copy link
Member

Ocramius commented Nov 3, 2022

🤔 ok, now that's where the mess starts: PHP 8.0 and 8.1 don't cleanly install at all?

Nothing to do with your work, heh.

I see that laminas/laminas-hydrator support could be expanded to ^4 perhaps: ^3 is really really old. That would get rid of some of these composer issues: also here, I recommend a conservative composer update nothing

@juicylime
Copy link
Author

There also looked to be a conflict with the laminas coding standard library so I went ahead and updated that too. Hopefully that wont pose any issues?

@juicylime
Copy link
Author

Ah I found another PR that addresses some of the issues going on here #23. The PR is still open so maybe there's some outstanding issues with the dependencies?

@juicylime
Copy link
Author

Looks like laminas-api-tools/api-tools-doctrine only supports until PHP 8.0 so something similar would need to be done there to extend it to 8.1 (If it doesn't break other packages in the process) and the PHP 8.1 tests would pass here once that package has been updated to support 8.1 as well.

I'm not so sure about the PHP 8.0 tests since there are issues with the phpro/zf-doctrine-hydration-module dependency and that only supports up until PHP ^7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PHP 8.1
2 participants