-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support range for PHP #25
base: 1.10.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Aman Ahlwat <[email protected]>
Hmm, I think this error is because CI didn't run in a while, and
|
🤔 ok, now that's where the mess starts: PHP 8.0 and 8.1 don't cleanly install at all? Nothing to do with your work, heh. I see that |
There also looked to be a conflict with the laminas coding standard library so I went ahead and updated that too. Hopefully that wont pose any issues? |
Ah I found another PR that addresses some of the issues going on here #23. The PR is still open so maybe there's some outstanding issues with the dependencies? |
Looks like laminas-api-tools/api-tools-doctrine only supports until PHP 8.0 so something similar would need to be done there to extend it to 8.1 (If it doesn't break other packages in the process) and the PHP 8.1 tests would pass here once that package has been updated to support 8.1 as well. I'm not so sure about the PHP 8.0 tests since there are issues with the phpro/zf-doctrine-hydration-module dependency and that only supports up until PHP ^7.0 |
Signed-off-by: Aman Ahlwat [email protected]
| New Feature | yes
Description
Extending the support range for PHP to support ~8.0
Fixes #24