Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASN.1 from RFC 6402 #23

Merged
merged 41 commits into from
Dec 20, 2023
Merged

Update ASN.1 from RFC 6402 #23

merged 41 commits into from
Dec 20, 2023

Conversation

mandelj7
Copy link
Collaborator

Added ASN.1 from RFC 6402 and removed the old text

@mandelj7 mandelj7 requested a review from seanturner as a code owner October 30, 2023 19:10
Copy link
Collaborator

@seanturner seanturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just adding ws and new lines.

draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
draft-mandel-lamps-rfc5272bis.md Outdated Show resolved Hide resolved
@seanturner
Copy link
Collaborator

Do we also need to add other algs to POPAlgs and WitnessAlgs, e.g.,

POPAlgs MAC-ALGORITHM ::= {
   maca-hMAC-SHA1       |
   maca-hMAC-SHA256     |
   maca-hMAC-SHA384     |
   maca-hMAC-SHA512     |
   maca-hMAC-SHA512-224 |
   maca-hMAC-SHA512-256 |
   maca-hMAC-SHA3-224   |
   maca-hMAC-SHA3-256   |
   maca-hMAC-SHA3-384   |
   maca-SHA3-512,
    ... }

and

WitnessAlgs DIGEST-ALGORITHM ::= {
   mda-sha1       |
   mda-sha256     |
   mda-SHA384     |
   mda-SHA512     |
   mda-SHA512-224 |
   mda-SHA512-256 |
   mda-SHA3-224   |
   mda-SHA3-256   |
   mda-SHA3-384   |
   mda-SHA3-512,
    ...}

@seanturner
Copy link
Collaborator

We also probably need to define a new module for kda-PBKDF2 to include the HMAC algorithms.

mandelj7 and others added 23 commits December 20, 2023 11:17
@mandelj7 mandelj7 merged commit b6a1149 into Update-ASN.1 Dec 20, 2023
2 checks passed
seanturner added a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants