Skip to content

Commit

Permalink
backport docker updates and fixes from edge
Browse files Browse the repository at this point in the history
  • Loading branch information
pirog committed Jan 18, 2025
1 parent 32a11f5 commit 383bb3b
Show file tree
Hide file tree
Showing 14 changed files with 33 additions and 16 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,15 @@ coverage/

# lando
.lando/id
FATCORE
checksums.txt
plugins/*
!plugins/healthcheck
!plugins/networking
!plugins/proxy
!plugins/scanner
!plugins/sharing
!plugins/test
FATCORE

# docs
.temp
Expand Down
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.github
.nyc_output
coverage
dist
docs
examples
guides
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})

* Fixed bug causing `--accept-license` flag to not work when installing Docker Desktop on macOS
* Updated default Docker Desktop version to `4.37.1|2`
* Updated default Docker Engine version to `27.5.0`
* Updated default Docker Compose version to `2.31.0`
* Updated recommended Docker Desktop range to `>=4.37.0`
* Updated tested Docker Desktop range to `<=4.37`
* Updated tested Docker Compose range to `<=2.32`

## v3.23.24 - [January 14, 2025](https://github.com/lando/core/releases/tag/v3.23.24)

* Fixed bug causing service script moving to fail when receiving non-stringy inputs
Expand Down
Empty file removed checksums.txt
Empty file.
8 changes: 4 additions & 4 deletions config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@ dockerSupportedVersions:
compose:
satisfies: "1.x.x || 2.x.x"
recommendUpdate: "<=2.24.6"
tested: "<=2.30.99"
tested: "<=2.32.99"
link:
linux: https://docs.docker.com/compose/install/#install-compose-on-linux-systems
darwin: https://docs.docker.com/desktop/install/mac-install/
win32: https://docs.docker.com/desktop/install/windows-install/
desktop:
satisfies: ">=4.0.0 <5"
tested: "<=4.36.99"
recommendUpdate: "<=4.34.0"
tested: "<=4.37.99"
recommendUpdate: "<=4.36"
link:
darwin: https://docs.docker.com/desktop/install/mac-install/
win32: https://docs.docker.com/desktop/install/windows-install/
wsl: https://docs.docker.com/desktop/install/windows-install/
engine:
satisfies: ">=18 <28"
tested: "<=27.3.1"
tested: "<=27.5.99"
link:
linux: https://docs.docker.com/engine/install/debian/#install-using-the-convenience-script
3 changes: 3 additions & 0 deletions hooks/lando-setup-build-engine-darwin.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const semver = require('semver');
const {color} = require('listr2');

const buildIds = {
'4.37.2': '179585',
'4.37.1': '178610',
'4.37.0': '178034',
'4.36.0': '175267',
'4.35.1': '173168',
'4.35.0': '172550',
Expand Down
2 changes: 2 additions & 0 deletions hooks/lando-setup-build-engine-win32.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ const {color} = require('listr2');
const {nanoid} = require('nanoid');

const buildIds = {
'4.37.1': '178610',
'4.37.0': '178034',
'4.36.0': '175267',
'4.35.1': '173168',
'4.35.0': '172550',
Expand Down
2 changes: 2 additions & 0 deletions hooks/lando-setup-build-engine-wsl.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const {color} = require('listr2');
const {nanoid} = require('nanoid');

const buildIds = {
'4.37.1': '178610',
'4.37.0': '178034',
'4.36.0': '175267',
'4.35.1': '173168',
'4.35.0': '172550',
Expand Down
4 changes: 2 additions & 2 deletions hooks/lando-setup-orchestrator.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const path = require('path');
/*
* Helper to get docker compose v2 download url
*/
const getComposeDownloadUrl = (version = '2.30.3') => {
const getComposeDownloadUrl = (version = '2.31.0') => {
const mv = version.split('.')[0] > 1 ? '2' : '1';
const arch = process.arch === 'arm64' ? 'aarch64' : 'x86_64';
const toggle = `${process.platform}-${mv}`;
Expand All @@ -31,7 +31,7 @@ const getComposeDownloadUrl = (version = '2.30.3') => {
/*
* Helper to get docker compose v2 download destination
*/
const getComposeDownloadDest = (base, version = '2.30.3') => {
const getComposeDownloadDest = (base, version = '2.31.0') => {
switch (process.platform) {
case 'linux':
case 'darwin':
Expand Down
2 changes: 1 addition & 1 deletion lib/daemon.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = class LandoDaemon {
log = new Log(),
context = 'node',
compose = require('../utils/get-compose-x')(),
orchestratorVersion = '2.30.3',
orchestratorVersion = '2.31.0',
userConfRoot = path.join(os.homedir(), '.lando'),
) {
this.cache = cache;
Expand Down
2 changes: 1 addition & 1 deletion scripts/install-docker-desktop.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ debug "INSTALLER: $INSTALLER"
debug "USER: $USER"

# add accept license if set
if [ "${DEBUG}" == 1 ]; then OPTS="$OPTS --accept-license"; fi
if [ "${ACCEPT_LICENSE}" == 1 ]; then OPTS="$OPTS --accept-license"; fi

# run
hdiutil attach "$INSTALLER"
Expand Down
2 changes: 1 addition & 1 deletion scripts/install-docker-engine.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -eo pipefail

DEBUG=0
INSTALLER="get-docker.sh"
VERSION="27.3.1"
VERSION="27.5.0"
OPTS=

debug() {
Expand Down
2 changes: 1 addition & 1 deletion utils/get-compose-x.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const getDockerBin = (bin, base, pathFallback = true) => {
}
};

module.exports = ({orchestratorVersion = '2.30.3', userConfRoot = os.tmpdir()} = {}) => {
module.exports = ({orchestratorVersion = '2.31.0', userConfRoot = os.tmpdir()} = {}) => {
const orchestratorBin = `docker-compose-v${orchestratorVersion}`;
switch (process.platform) {
case 'darwin':
Expand Down
10 changes: 5 additions & 5 deletions utils/get-config-defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ const os = require('os');
const getBuildEngineVersion = (platform = process.landoPlatform ?? process.platform) => {
switch (platform) {
case 'darwin':
return '4.36.0';
return '4.37.2';
case 'linux':
return '27.3.1';
return '27.5.0';
case 'win32':
return '4.36.0';
return '4.37.1';
case 'wsl':
return '4.36.0';
return '4.37.1';
}
};

// Default config
const defaultConfig = options => ({
orchestratorSeparator: '_',
orchestratorVersion: '2.30.3',
orchestratorVersion: '2.31.0',
configSources: [],
coreBase: path.resolve(__dirname, '..'),
disablePlugins: [],
Expand Down

0 comments on commit 383bb3b

Please sign in to comment.