feat(community): Provide fallback relationshipType in case it is not present in graph_transformer #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
hlminh2000
changed the title
dosubot
bot
added
auto:nit
jacoblee93
reviewed
Jan 18, 2025
| @@ -254,6 +258,7 @@ export class LLMGraphTransformer { | |||
| strictMode = true, | |||
| nodeProperties = [], | |||
| relationshipProperties = [], | |||
| fallbackRelationshipType = "unknown, | |||
There was a problem hiding this comment.
Think you're missing a quote here!
And don't forget to run yarn format
jacoblee93
reviewed
Jan 18, 2025
|
Actually, can you make the default fallback relationship type Null, so the default behavior isn't changed. When the fallback relationship is configured, then you can use it as fallback. Also describe the new attribute in docstring please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although difficult to reproduce, I've ran into a few times when
relationshipTypewas undefined and so the extraction fails.In these cases I'd still like to have the relationship being captured in my knowledge graph, so it seems appropriate to provide the transformer with a fallback value it can use, in this case defaulted to
"unknown". This also allows for the value to be overridden with something else in cases where"unknown"already means something in an existing context.I'm happy to contribute to anything that may need to be updated to reflect this info, like documentations, just need a pointer :)