Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1.0): unexpected error raise #12812

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 17, 2025

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

First

71d198310db93b12262e05e12f28f2f
This will raise None type has no attribute 'get'

Second

f80c50462ffcbe735f9acc38d656dee
the expected Tool with name not found error will not raised

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 17, 2025
@yihong0618
Copy link
Contributor

nice catch

@crazywoola crazywoola added this to the 1.0 milestone Jan 20, 2025
@crazywoola crazywoola merged commit de4752a into langgenius:plugins/beta Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants