-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beeflow:useContainer support for SquashFS #990
beeflow:useContainer support for SquashFS #990
Conversation
401c2c8
to
68c2a51
Compare
I'm currently not checking if We could throw an error earlier with something like |
Could this be tested in our github ci, I don't think we have Squash fuse installed. |
I made a debug test to run in CI to see if =================================== FAILURES ===================================
_________________________ test_debug_check_fusermount3 _________________________
def test_debug_check_fusermount3():
"""Debug check if system has `fusermount3`."""
> assert shutil.which('fusermount3') is None
E AssertionError: assert '/usr/bin/fusermount3' is None
E + where '/usr/bin/fusermount3' = <function which at 0x7f5cc7b41990>('fusermount3')
E + where <function which at 0x7f5cc7b41990> = shutil.which
beeflow/tests/test_charliecloud_driver.py:76: AssertionError I believe |
3501a27
to
ee7921d
Compare
Note: Unit tests failure in the CI right now seems to be when its trying to update the coverage badge. This branch is a bit out of date with |
I think we can let Charliecloud handle what happens if the requirement for sqfs doesn't exist. I just had an error. It did it fairly well when I tried the .sqfs conatiner using the develop branch. The clamr task failed and the workflow failed due to that. I was able to find the errors in the stderr file. |
This looks good, can you get the unit tests cleared up? |
…at-are-charliecloud-sqfs-format-dockerrequirement-for-tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well and looks great. Thanks for adding the test.
Closes #967
Enables the use of
SquashFS
format for theDockerRequirement
beeflow:useContainer
.I tested this by modifying the clamr example's
clamr_wf.cwl
file and changed the twoDockerRequirement
s to be:Where
clamr-ffmpeg.sqfs
was made using theDockerfile
included with the example.