Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SchedulerRequirement to SlurmRequirement; add qos and reservation #996

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

pagrubel
Copy link
Collaborator

@pagrubel pagrubel commented Jan 27, 2025

Closes #989
This pull request renames the beeflow:SchedulerRequirement for job requirements to the slurmworker with the better descriptive beeflow:SlurmRequirement, and adds defining qos and reservation as requirement attributes.

@pagrubel pagrubel added enhancement New feature or request WIP Work in progress labels Jan 27, 2025
@pagrubel pagrubel removed the WIP Work in progress label Jan 28, 2025
@pagrubel pagrubel requested a review from rstyd January 28, 2025 00:11
@pagrubel pagrubel self-assigned this Jan 28, 2025
Copy link
Collaborator

@rstyd rstyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Approved

@pagrubel pagrubel merged commit f12751a into develop Feb 3, 2025
5 of 6 checks passed
@pagrubel pagrubel deleted the issue#989-SlurmRequirements-qos-reservation branch February 3, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capabilities to beeflow:SchedulerRequirement
2 participants