feat: Add config instance #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous code, `config` was a class-level variable, which caused only one instance of `config` to be used when using this gem package. However, In my business, I need to use multiple configurations. This code is no longer available. Idea: Change all previous module-level operations to class level and create a global client during initialization. Define the method signatures on the module as before and call using the global client. This makes it compatible with the previous code as much as possible. The downside is that previously at module level we had global variables, now they are defined within each respective client Here are explanations for the additional clients: WechatPay::Config=>Replaces the previous WechatPay.app_id=xxx WechatPay::Client=>Replaces the previous WechatPayHelper and is mainly responsible for interacting with WeChat. WechatPay::Direct::Direct=>Replaces the previous WechatPay::Direct module WechatPay::Ecommerce::Ecommerce=>Replaces the previous WechatPay::Ecommerce module WechatPay::Sign=>Replaces previously Wechatpay::Sigɲ module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is an excellent project which has greatly facilitated my development. However, in my business scenario, I need to use multiple configurations. Hence, this pull request.
configwas a class-level variable, which caused only one instance ofconfigto be used when using this gem package. However, In my business, I need to use multiple configurations. This code is no longer available.Idea:
Change all previous module-level operations to class level and create a global client during initialization. Define the method signatures on the module as before and call using the global client. This makes it compatible with the previous code as much as possible. The downside is that previously at module level we had global variables, now they are defined within each
respective client
Here are explanations for the additional clients:
WechatPay::Config=>Replaces the previous WechatPay.app_id=xxx WechatPay::Client=>Replaces the previous WechatPayHelper and is mainly responsible for interacting with WeChat. WechatPay::Direct::Direct=>Replaces the previous WechatPay::Direct module WechatPay::Ecommerce::Ecommerce=>Replaces the previous WechatPay::Ecommerce module WechatPay::Sign=>Replaces previously Wechatpay::Sigɲ module