Update wgpu, Peniko, and Vello #741
Conversation
waywardmonkeys
force-pushed
the
update-wgpu-peniko-vello
branch
from
724660e to
680a9e9
Compare
|
This is a draft and not fully working yet (doesn't compile). The actual update of Vello isn't here yet until I finish up the changes for brush and gradient interpolation to at least get them to compile. |
There was a problem hiding this comment.
The bulk of the changes are quite dull.
- Color constants are referenced from
color::palette::cssrather than named constants on theColortype. - Use
with_alpharather thanmultiply_alphasince we're just using this to set the alpha. - Use
Color::from_rgb8andColor::from_rgba8rather thanColor::rgb8andColor::rgba8.
| @@ -16,5 +16,5 @@ wgpu = { workspace = true } | |||
| futures = "0.3.26" | |||
| anyhow = "1.0.69" | |||
| swash = "0.1.8" | |||
| floem-vger-rs = { version = "0.3.1", package = "floem-vger" } | |||
| floem-vger-rs = { git = "https://github.com/lapce/vger-rs.git", rev = "b2441cc85b1d555a3c74e2cdced08382460759df", version = "0.3.1", package = "floem-vger" } | |||
There was a problem hiding this comment.
This will need a release before this can land.
| #[allow(clippy::type_complexity)] | ||
| glyph_cache: HashMap<(CacheKey, Color), (CacheColor, Option<Rc<Glyph>>)>, | ||
| glyph_cache: HashMap<(CacheKey, u32), (CacheColor, Option<Rc<Glyph>>)>, |
There was a problem hiding this comment.
With color, the Color (really AlphaColor<Srgb>) is using f32, so it isn't Hash or Eq. We have a way to work around this with a wrapper type, but since here we're just dropping down to u8 colors anyway, I thought this might be okay here. I'm not sure though.
There was a problem hiding this comment.
This looks like a good solution here.
waywardmonkeys
force-pushed
the
update-wgpu-peniko-vello
branch
from
680a9e9 to
59d7daa
Compare
waywardmonkeys
changed the title
waywardmonkeys
force-pushed
the
update-wgpu-peniko-vello
branch
from
59d7daa to
9583f31
Compare
Convert the code for solid/gradient interpolation.
waywardmonkeys
force-pushed
the
update-wgpu-peniko-vello
branch
from
9583f31 to
bc0b489
Compare
|
Thanks for doing this! It is very appreciated |
Update to Vello 0.4, Peniko 0.3.1, and wgpu 23.0.1. This brings with it the new
colorcrate that Vello and Peniko use.This currently disables interpolation of gradients.