Prevent users from creating more than 5 forum threads per day #1161 #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/Http/Controllers/Forum/ThreadsController.php
driesvints
requested changes
Oct 29, 2024
| }); | ||
|
|
||
| // Check if the user has reached the limit | ||
| if ($threadCount >= getenv('APP_MAX_THREAD_COUNT')) { |
There was a problem hiding this comment.
This can be a fixed value. No need to pull from a config or env.
| return Thread::where('author_id', $userId) | ||
| ->where('created_at', '>=', now()->startOfDay()) | ||
| ->count(); | ||
| }); |
There was a problem hiding this comment.
I wouldn't cache the results tbh. Maybe we can simply get the count by default with withCount: https://laravel.com/docs/11.x/eloquent-relationships#counting-related-models
There was a problem hiding this comment.
@driesvints can i use default alert of javascript
There was a problem hiding this comment.
In an ideal world I'd add a new "warning" method to SendsAlerts that gets implemented in the UI as well. But let's use $this->error( for now.
|
Thanks a bunch! Did a couple of changes myself here. |
|
@iam-subho Thanks for this PR, this will prevent an amount of spam that we need to remove 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.