Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warnings_as_errors #2

Open
wants to merge 1 commit into
base: fifo-0.9.2
Choose a base branch
from

Conversation

efcasado
Copy link

@efcasado efcasado commented Mar 6, 2018

This is a bit of a blocker when trying to use this fork in an Elixir project using Elixir 1.6 and Erlang/OTP 20.

@cmeiklejohn
Copy link
Member

Thanks, can I ask what you're using this for? The fifo-0.9.2 branch of my fork is no longer maintained.

@cmeiklejohn
Copy link
Member

What would be a better fix here is if we adapt the code so we can keep warnings_as_errors but fix the things that are warning.

@efcasado
Copy link
Author

efcasado commented Mar 6, 2018

I went for fifo-0.9.2 because it is the default branch in your repo. It seemed to be the most trustworthy source for the latest and greatest version of riak_core after Basho's goodbye. Any suggestions on which one should I use?

I agree that the shortest path is not always the best option. I'll look into providing a less lazy solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants