Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firstaid index #1628

Merged
merged 13 commits into from
Jan 26, 2025
Merged

Firstaid index #1628

merged 13 commits into from
Jan 26, 2025

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • [n/a] Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • [n/a] ltnewsX.tex (and/or latexchanges.tex) updated

first aid for index package to work with 2025/06 release (might be updated by then but ...

@u-fischer
Copy link
Member

This doesn't reimplement the code from index that allows to use \index commands with optional argument in sectioning commands:

\documentclass{book}
\usepackage{index}
\makeindex
\pagestyle{headings}
\begin{document}
\showoutput
\tableofcontents
\chapter{\index[default]{blub} abc}
\section{\index[default]{bla} abc}
x \newpage x \newpage x \newpage
\end{document}

gives faulty headers (with this firstaid code):

image

@FrankMittelbach
Copy link
Member Author

This doesn't reimplement the code from index that allows to use \index commands with optional argument in sectioning commands:

yes, but that doesn't have to go into the firstaid, it should really go into core LaTeX (just didn't got around doing that yet), but it needs to come as well, but I thought of doing this as a separate pr because I hope that this first aid can go out soon again).

@FrankMittelbach FrankMittelbach requested review from u-fischer and davidcarlisle and removed request for davidcarlisle and u-fischer January 24, 2025 14:35
@FrankMittelbach FrankMittelbach merged commit 5d3a5d4 into develop Jan 26, 2025
86 checks passed
@FrankMittelbach FrankMittelbach deleted the firstaid-index branch January 26, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants