Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for textcolor for gh1474 #1629

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Update documentation for textcolor for gh1474 #1629

merged 8 commits into from
Jan 23, 2025

Conversation

u-fischer
Copy link
Member

#1474

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • [n/a] Test file(s) added
  • Version and date string updated in changed source files (only date)
  • [n/a] Relevant \changes entries in source included
  • [n/a] Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • [n/a] ltnewsX.tex (and/or latexchanges.tex) updated

required/graphics/grfguide.tex Outdated Show resolved Hide resolved
required/graphics/grfguide.tex Outdated Show resolved Hide resolved
@FrankMittelbach
Copy link
Member

Are we sure this doesn't warrant an entry in ltnews? It is not a code improvement, but it is a fact that we can't really change and thus worth pointing out there imho

@u-fischer
Copy link
Member Author

Are we sure this doesn't warrant an entry in ltnews? It is not a code improvement, but it is a fact that we can't really change and thus worth pointing out there imho

I added an entry. OK so?

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a suggestion


In contrast to other \cs{text}-commands like \cs{textbf} or \cs{textrm},
the command \cs{textcolor} gobbles spaces at the start of its argument, so \verb=Hello\textcolor{red}{ World}= will output Hello\textcolor{red}{ World}.
This behaviour has now been clarified in the documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are technical as well as compatibility reasons for this, so the behavior will not change. This has now been clarified ...

@u-fischer u-fischer merged commit b5d6c2d into develop Jan 23, 2025
86 checks passed
@u-fischer u-fischer deleted the gh1474 branch January 23, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants