Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

ci: fixing publish docs secrets issue #87

Merged
merged 2 commits into from
Feb 20, 2024
Merged

ci: fixing publish docs secrets issue #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b28ca5
ci: fixing publish docs secrets issue
tanderson-ld Feb 20, 2024
2990834
updating name of release secrets step
tanderson-ld Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/manual-publish-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ jobs:
contents: write # Needed in this case to write github pages.
steps:
- uses: actions/checkout@v4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the secret needed for the CI workflow? We may have problems when it comes to contributor PRs that cannot use secrets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the current setup, the workflow files are the ones that set up the AWS role. When I went to trigger docs manually, realized I forgot it in this workflow.

- uses: launchdarkly/gh-actions/actions/[email protected]
name: Assume aws role
with:
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}

- id: build
name: Build and Test
uses: ./.github/actions/ci
Expand Down
Loading