Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components)!: handle external links with useHref wrapper #1361

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Niznikr
Copy link
Contributor

@Niznikr Niznikr commented Jul 15, 2024

Summary

Per the RAC team's recommendation, we can wrap useHref and mimic RR's detection of external links so that consumer's don't need to deal with a separate ExternalLink component.

@Niznikr Niznikr requested review from antonio-darkly and a team as code owners July 15, 2024 20:28
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 85b72b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@launchpad-ui/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Size Change: +34 B (+0.02%)

Total Size: 208 kB

Filename Size Change
packages/components/dist/index.es.js 9.82 kB +26 B (+0.27%)
packages/components/dist/index.js 9.77 kB +8 B (+0.08%)
ℹ️ View Unchanged
Filename Size
packages/alert/dist/index.es.js 1.3 kB
packages/alert/dist/index.js 1.37 kB
packages/alert/dist/style.css 1.3 kB
packages/avatar/dist/index.es.js 1.12 kB
packages/avatar/dist/index.js 1.19 kB
packages/avatar/dist/style.css 404 B
packages/banner/dist/index.es.js 624 B
packages/banner/dist/index.js 695 B
packages/banner/dist/style.css 469 B
packages/box/dist/index.es.js 6.68 kB
packages/box/dist/index.js 6.78 kB
packages/box/dist/style.css 2.25 kB
packages/button/dist/index.es.js 1.81 kB
packages/button/dist/index.js 1.89 kB
packages/button/dist/style.css 2.97 kB
packages/card/dist/index.es.js 688 B
packages/card/dist/index.js 754 B
packages/card/dist/style.css 666 B
packages/chip/dist/index.es.js 645 B
packages/chip/dist/index.js 714 B
packages/chip/dist/style.css 499 B
packages/clipboard/dist/index.es.js 1.49 kB
packages/clipboard/dist/index.js 1.57 kB
packages/clipboard/dist/style.css 802 B
packages/collapsible/dist/index.es.js 856 B
packages/collapsible/dist/index.js 926 B
packages/collapsible/dist/style.css 81 B
packages/columns/dist/index.es.js 579 B
packages/columns/dist/index.js 651 B
packages/columns/dist/style.css 281 B
packages/components/dist/style.css 6.1 kB
packages/core/dist/index.es.js 1.14 kB
packages/core/dist/index.js 1.52 kB
packages/counter/dist/index.es.js 330 B
packages/counter/dist/index.js 397 B
packages/counter/dist/style.css 248 B
packages/data-table/dist/index.es.js 2.47 kB
packages/data-table/dist/index.js 2.54 kB
packages/data-table/dist/style.css 474 B
packages/drawer/dist/index.es.js 1.7 kB
packages/drawer/dist/index.js 2.25 kB
packages/drawer/dist/style.css 490 B
packages/dropdown/dist/index.es.js 1.14 kB
packages/dropdown/dist/index.js 1.2 kB
packages/filter/dist/index.es.js 2.28 kB
packages/filter/dist/index.js 2.35 kB
packages/filter/dist/style.css 907 B
packages/focus-trap/dist/index.es.js 267 B
packages/focus-trap/dist/index.js 333 B
packages/form/dist/index.es.js 4.13 kB
packages/form/dist/index.js 4.24 kB
packages/form/dist/style.css 2.21 kB
packages/icons/dist/index.es.js 1.3 kB
packages/icons/dist/index.js 1.37 kB
packages/icons/dist/style.css 457 B
packages/inline-edit/dist/index.es.js 1.57 kB
packages/inline-edit/dist/index.js 1.65 kB
packages/inline-edit/dist/style.css 329 B
packages/inline/dist/index.es.js 572 B
packages/inline/dist/index.js 643 B
packages/inline/dist/style.css 243 B
packages/markdown/dist/index.es.js 963 B
packages/markdown/dist/index.js 1.04 kB
packages/markdown/dist/style.css 224 B
packages/menu/dist/index.es.js 3.8 kB
packages/menu/dist/index.js 3.88 kB
packages/menu/dist/style.css 862 B
packages/modal/dist/index.es.js 2.97 kB
packages/modal/dist/index.js 3.54 kB
packages/modal/dist/style.css 900 B
packages/navigation/dist/index.es.js 2.73 kB
packages/navigation/dist/index.js 2.81 kB
packages/navigation/dist/style.css 866 B
packages/overlay/dist/index.es.js 1.03 kB
packages/overlay/dist/index.js 1.09 kB
packages/pagination/dist/index.es.js 1.15 kB
packages/pagination/dist/index.js 1.23 kB
packages/pagination/dist/style.css 300 B
packages/popover/dist/index.es.js 3.06 kB
packages/popover/dist/index.js 3.56 kB
packages/popover/dist/style.css 514 B
packages/portal/dist/index.es.js 398 B
packages/portal/dist/index.js 457 B
packages/progress-bubbles/dist/index.es.js 1.76 kB
packages/progress-bubbles/dist/index.js 1.83 kB
packages/progress-bubbles/dist/style.css 817 B
packages/progress/dist/index.es.js 1.02 kB
packages/progress/dist/index.js 1.09 kB
packages/progress/dist/style.css 267 B
packages/select/dist/index.es.js 5.85 kB
packages/select/dist/index.js 5.94 kB
packages/select/dist/style.css 1.12 kB
packages/slider/dist/index.es.js 570 B
packages/slider/dist/index.js 637 B
packages/slider/dist/style.css 613 B
packages/snackbar/dist/index.es.js 1.15 kB
packages/snackbar/dist/index.js 1.71 kB
packages/snackbar/dist/style.css 529 B
packages/split-button/dist/index.es.js 940 B
packages/split-button/dist/index.js 1.01 kB
packages/split-button/dist/style.css 500 B
packages/stack/dist/index.es.js 464 B
packages/stack/dist/index.js 535 B
packages/stack/dist/style.css 181 B
packages/tab-list/dist/index.es.js 728 B
packages/tab-list/dist/index.js 801 B
packages/tab-list/dist/style.css 410 B
packages/table/dist/index.es.js 931 B
packages/table/dist/index.js 1.01 kB
packages/table/dist/style.css 689 B
packages/tag/dist/index.es.js 2.86 kB
packages/tag/dist/index.js 2.94 kB
packages/tag/dist/style.css 740 B
packages/toast/dist/index.es.js 956 B
packages/toast/dist/index.js 1.51 kB
packages/toast/dist/style.css 466 B
packages/toggle/dist/index.es.js 723 B
packages/toggle/dist/index.js 805 B
packages/toggle/dist/style.css 1.1 kB
packages/tokens/dist/index.css 2.48 kB
packages/tokens/dist/index.es.js 3 kB
packages/tokens/dist/index.js 3.01 kB
packages/tokens/dist/media-queries.css 114 B
packages/tokens/dist/themes.css 1.69 kB
packages/tooltip/dist/index.es.js 506 B
packages/tooltip/dist/index.js 581 B
packages/tooltip/dist/style.css 331 B
packages/vars/dist/index.es.js 2.67 kB
packages/vars/dist/index.js 2.74 kB

compressed-size-action

@Niznikr Niznikr requested a review from apucacao August 1, 2024 13:35
@Niznikr Niznikr merged commit 2169c64 into main Aug 5, 2024
22 checks passed
@Niznikr Niznikr deleted the refactor/external-links branch August 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants