Skip to content

Commit

Permalink
fix(deps): bump supported Go versions to 1.24.0 and 1.23.6 (#477)
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] authored Feb 19, 2025
1 parent cbefb3c commit 2e67f14
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/variables/go-versions.env
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
latest=1.23.6
penultimate=1.22.12
latest=1.24.0
penultimate=1.23.6
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# This is a standalone Dockerfile that does not depend on goreleaser building the binary
# It is NOT the version that is pushed to dockerhub
FROM golang:1.23.6-alpine3.21 as builder
FROM golang:1.24.0-alpine3.21 as builder
# See "Runtime platform versions" in CONTRIBUTING.md

RUN apk --no-cache add \
Expand Down
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

GOLANGCI_LINT_VERSION=v1.60.1
GOLANGCI_LINT_VERSION=v1.64.5

LINTER=./bin/golangci-lint
LINTER_VERSION_FILE=./bin/.golangci-lint-version-$(GOLANGCI_LINT_VERSION)
Expand Down
2 changes: 1 addition & 1 deletion internal/bigsegments/store_redis.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func (r *redisBigSegmentStore) GetSynchronizedOn() (ldtime.UnixMillisecondTime,
if err != nil {
return 0, err
}
return ldtime.UnixMillisecondTime(milliseconds), nil
return ldtime.UnixMillisecondTime(milliseconds), nil //nolint: gosec
}

func (r *redisBigSegmentStore) Close() error {
Expand Down
2 changes: 1 addition & 1 deletion internal/envfactory/env_rep.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (e ExpiringKeyRep) ToParams() ExpiringSDKKey {
}

func ToTime(millisecondTime ldtime.UnixMillisecondTime) time.Time {
return time.UnixMilli(int64(millisecondTime))
return time.UnixMilli(int64(millisecondTime)) //nolint: gosec
}

// ToParams converts the JSON properties for an environment into our internal parameter type.
Expand Down
2 changes: 1 addition & 1 deletion relay/endpoints_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func statusHandler(relay *Relay) http.Handler {
bigSegmentStatus.LastSynchronizedOn = synchronizedOn
now := ldtime.UnixMillisNow()
stalenessThreshold := relay.config.Main.BigSegmentsStaleThreshold.GetOrElse(config.DefaultBigSegmentsStaleThreshold)
if !synchronizedOn.IsDefined() || now > (synchronizedOn+ldtime.UnixMillisecondTime(stalenessThreshold.Milliseconds())) {
if !synchronizedOn.IsDefined() || now > (synchronizedOn+ldtime.UnixMillisecondTime(stalenessThreshold.Milliseconds())) { //nolint: gosec
bigSegmentStatus.PotentiallyStale = true
if relay.config.Main.BigSegmentsStaleAsDegraded {
healthy = false
Expand Down

0 comments on commit 2e67f14

Please sign in to comment.