Skip to content

Commit

Permalink
g2o: fixed iterative optimization (when epsilon>0) not converging as …
Browse files Browse the repository at this point in the history
…fast as like batch optimization (and not converging at all in some cases).
  • Loading branch information
matlabbe committed Jan 27, 2025
1 parent 3ab9a69 commit 6aa188d
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion corelib/src/optimizer/OptimizerG2O.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1037,6 +1037,12 @@ std::map<int, Transform> OptimizerG2O::optimize(
int it = 0;
UTimer timer;
double lastError = 0.0;

if (!optimizer.solver()->init()) {
UERROR("g2o: Error while initializing solver");
return optimizedPoses;
}

if(intermediateGraphes || this->epsilon() > 0.0)
{
for(int i=0; i<iterations(); ++i)
Expand Down Expand Up @@ -1150,7 +1156,8 @@ std::map<int, Transform> OptimizerG2O::optimize(
}
}

it += optimizer.optimize(1);
g2o::OptimizationAlgorithm::SolverResult result = optimizer.solver()->solve(i);
++it;

// early stop condition
optimizer.computeActiveErrors();
Expand All @@ -1163,6 +1170,12 @@ std::map<int, Transform> OptimizerG2O::optimize(
return optimizedPoses;
}

if(result == g2o::OptimizationAlgorithm::Fail)
{
UERROR("g2o: Solver failed, aborting optimization!");
return optimizedPoses;
}

double errorDelta = lastError - chi2;
if(i>0 && errorDelta < this->epsilon())
{
Expand Down

0 comments on commit 6aa188d

Please sign in to comment.