feat: encode sparse lua arrays as json map (object) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain Kong error message are in the following format which indicate
index value for error in an array:
```
errors = {
config = {
response_if_status_code = {
[2] = "value should be between 100 and 599"
}
}
}
```
This fix allows for sparse array and converts the key (which is the
index in this case) into part of the error message.
* test: add a test for UserData removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my suggestion it is possible to represent sparse arrays from lua in a useful way in JSON by representing them as a map. Therefore I use the index of the lua array as key in the JSON map.
Lua:
{ 1, 2, [10] = 3 }=> JSON
{ "1": 1, "10": 3, "2": 2 }If there are no holes in the lua array, a normal JSON array will still be output:
Lua:
{1, 2, 3, 4, 5}JSON:
[1, 2, 3, 4, 5]In contrast to the pull request #12, the index/key can be usefully processed further and easily retrieved.