LMB 1353 | Make rangorde a dropdown #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7c9e2c4.
…ed in two places with the same implementation)
… mandatarissen outside current period
JonasVanHoof
commented
Feb 27, 2025
Comment on lines
+41
to
+45
| const currentBestuursperiode = | ||
| await this.bestuursperioden.getCurrentBestuursperiode(); | ||
| const isEditingInPast = | ||
| parentModel.selectedBestuursperiode.id !== currentBestuursperiode.id; | ||
|
|
There was a problem hiding this comment.
Added this as wijzig mandatarissen for a period other than the current period it shows multiple mandatarissen in the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of a text input field we want the rangorde to be shown as a dropdown with the options 1-...100 so the user can only select a valid rangorde. The up and down arrows stay visible next to the dropdown so they can go up and down with automatic reordering of the mandataris with rangorde.
How to test
Do these test in edit-rangorde (organen) and in the IV page
Attachements
On IV page
In the mandataris form
On the edit-rangorde page
