Add configuration placeholder %%ldcversion%% #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang does something similar with library folders. Indeed it would help a lot to easily support multiple compiler versions on the same system. |
thewilsonator
approved these changes
Jan 5, 2025
JohanEngelen
reviewed
Jan 5, 2025
| @@ -110,11 +110,18 @@ struct CfgPaths | |||
| } | |||
| } | |||
|
|
|||
| extern(C++, "ldc") | |||
| { | |||
| extern __gshared const(const(char) *) ldc_version; | |||
There was a problem hiding this comment.
This is not needed. Please use global.ldc_version which is already a dstring type (import dmd.globals).
| string replacePlaceholders(string str, CfgPaths cfgPaths) | ||
| { | ||
| const dVersion = ldc_version[0..strlen(ldc_version)]; |
There was a problem hiding this comment.
As mentioned above, please use dmd.globals.ldc_version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this introduces a placeholder for
ldc2.confwhich is set to the version of LDC.The rationale is: when following the "Cross-compiling with LDC" on a linux system, according to section "Default libraries", it is required to download prebuilt runtimes of the version matching the host compiler.
Since the host compiler is subject to system updates, I might find myself in a situation of version mismatch if I forget to update target libraries.
Favoring versioned directories may work as a preventive measure against such cases.