Gracefully handle analytics failing to send (patrol_cli) #2509
Conversation
alexandradeas
requested review from
pdenert,
piotruela and
mateuszwojtczak
as code owners
|
To view this pull requests documentation preview, visit the following URL: docs.page/leancodepl/patrol~2509 Documentation is deployed and generated using docs.page. |
github-actions
bot
added
the
package: patrol_cli
alexandradeas
force-pushed
the
master
branch
2 times, most recently
from
a51698e to
7b43be8
Compare
There was a problem hiding this comment.
@alexandradeas thanks for contribution! You're right, this should be done like that from the begging. Please change the changelog, and than we can merge this.
packages/patrol_cli/CHANGELOG.md
Outdated
| ## 3.5.1 | ||
| - Gracefully handle when analytics fail to send (#2460) |
There was a problem hiding this comment.
Please change version to Unreleased and add empty line between (for formatting purposes)
| ## 3.5.1 | |
| - Gracefully handle when analytics fail to send (#2460) | |
| ## Unreleased | |
| - Gracefully handle when analytics fail to send. (#2460) |
my bad for not reading the instructions properly, updated that now |
|
Thanks again for contribution @alexandradeas |
Handle exceptions raised when analytics fail to be sent.
This is related to #2460 where I ran into the same due to a DNS block on the domain - which I'd expect to be common in CI environments where egress is tightly controlled. As analytics aren't an essential part of the CLI, my rationale is that if the call fails it should not halt execution