Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheerp x idb device #211

Merged
merged 10 commits into from
Feb 10, 2025
Merged

Cheerp x idb device #211

merged 10 commits into from
Feb 10, 2025
+160 −35

Conversation

AtibQur
Copy link
Contributor

@AtibQur AtibQur commented Jan 30, 2025

No description provided.

GabrielaReyna
GabrielaReyna requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@GabrielaReyna GabrielaReyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! just some comments added :)

sites/cheerpx/src/content/docs/11-guides/File-System-support.md Show resolved Hide resolved
sites/cheerpx/src/content/docs/11-guides/File-System-support.md Show resolved Hide resolved
sites/cheerpx/src/content/docs/12-reference/CheerpX.IDBDevice/create.md Show resolved Hide resolved
sites/cheerpx/src/content/docs/12-reference/CheerpX.IDBDevice/readFileAsBlob.md Outdated Show resolved Hide resolved
sites/cheerpx/src/content/docs/12-reference/CheerpX.IDBDevice/readFileAsBlob.md Show resolved Hide resolved
sites/cheerpx/src/content/docs/20-faq.md Outdated Show resolved Hide resolved
@AtibQur AtibQur requested a review from GabrielaReyna February 4, 2025 11:11
GabrielaReyna
GabrielaReyna approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@GabrielaReyna GabrielaReyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@GabrielaReyna GabrielaReyna merged commit e836ffb into main Feb 10, 2025
9 checks passed
@GabrielaReyna GabrielaReyna deleted the CheerpX_IDBDevice branch February 10, 2025 16:10
@GabrielaReyna GabrielaReyna mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielaReyna GabrielaReyna GabrielaReyna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtibQur @GabrielaReyna