Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(AtTop/Monoid): add multiplicative versions #21878

Closed
wants to merge 12 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 14, 2025

Also review names in the file.

Moves:

  • Filter.Tendsto.atTop_mul_atTop ->Filter.Tendsto.atTop_mul_atTop₀
  • Filter.Tendsto.atBot_mul_atBot ->Filter.Tendsto.atBot_mul_atBot₀
  • Filter.Tendsto.atTop_of_mul_const -> Filter.Tendsto.atTop_of_mul_const₀
  • Filter.Tendsto.atTop_of_const_mul -> Filter.Tendsto.atTop_of_const_mul₀

Open in Gitpod

@urkud urkud added t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order theory labels Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

PR summary 1587d356e9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Tendsto.atBot_mul_atBot₀
+ Tendsto.atBot_mul_atTop₀
+ Tendsto.atBot_mul_eventuallyLE_one
+ Tendsto.atBot_mul_le_one
+ Tendsto.atBot_of_const_le_mul
+ Tendsto.atBot_of_const_mul
+ Tendsto.atBot_of_isBoundedUnder_ge_mul
+ Tendsto.atBot_of_mul_const
+ Tendsto.atBot_of_mul_const_le
+ Tendsto.atBot_of_mul_isBoundedUnder_ge
+ Tendsto.atBot_pow
+ Tendsto.atTop_mul_atBot₀
+ Tendsto.atTop_mul_atTop₀
+ Tendsto.atTop_mul_one_eventuallyLE
+ Tendsto.atTop_mul_one_le
+ Tendsto.atTop_of_const_mul₀
+ Tendsto.atTop_of_isBoundedUnder_le_mul
+ Tendsto.atTop_of_le_const_mul
+ Tendsto.atTop_of_mul_const₀
+ Tendsto.atTop_of_mul_isBoundedUnder_le
+ Tendsto.atTop_of_mul_le_const
+ Tendsto.atTop_pow
+ Tendsto.eventuallyLE_one_mul_atBot
+ Tendsto.le_one_mul_atBot
+ Tendsto.one_eventuallyLE_mul_atTop
+ Tendsto.one_le_mul_atTop
- Tendsto.nsmul_atBot
- Tendsto.nsmul_atTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (6.00, 0.00)
Current number Change Type
3368 -6 porting notes

Current commit 1587d356e9
Reference commit 2bcc5cd542

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm content with this.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Feb 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 19, 2025
Also review names in the file.

Moves:
- Filter.Tendsto.atTop_mul_atTop ->Filter.Tendsto.atTop_mul_atTop₀
- Filter.Tendsto.atBot_mul_atBot ->Filter.Tendsto.atBot_mul_atBot₀
- Filter.Tendsto.atTop_of_mul_const -> Filter.Tendsto.atTop_of_mul_const₀
- Filter.Tendsto.atTop_of_const_mul -> Filter.Tendsto.atTop_of_const_mul₀
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(AtTop/Monoid): add multiplicative versions [Merged by Bors] - chore(AtTop/Monoid): add multiplicative versions Feb 19, 2025
@mathlib-bors mathlib-bors bot closed this Feb 19, 2025
@mathlib-bors mathlib-bors bot deleted the YK-grp-attop branch February 19, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-order Order theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants