Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable Elab.async on the cmdline #6985

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −0
Draft

chore: re-enable Elab.async on the cmdline #6985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc388aa
try re-enabling Elab.async on the cmdline
Kha Feb 7, 2025
4566ffd
chore: do not include wait time in "type checking" profile
Kha Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Lean/AddDecl.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ def addDecl (decl : Declaration) : CoreM Unit := do
let endRange? := (← getRef).getTailPos?.map fun pos => ⟨pos, pos⟩
Core.logSnapshotTask { range? := endRange?, task := t }
where doAdd := do
-- do not include waiting for previous kernel invocations in profile
let _ ← IO.wait (← getEnv).checked
profileitM Exception "type checking" (← getOptions) do
withTraceNode `Kernel (fun _ => return m!"typechecking declarations {decl.getNames}") do
if !(← MonadLog.hasErrors) && decl.hasSorry then
Expand Down
1 change: 1 addition & 0 deletions src/Lean/Elab/Frontend.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ def runFrontend
let startTime := (← IO.monoNanosNow).toFloat / 1000000000
let inputCtx := Parser.mkInputContext input fileName
let opts := Language.Lean.internal.cmdlineSnapshots.setIfNotSet opts true
let opts := Elab.async.setIfNotSet opts true
let ctx := { inputCtx with }
let processor := Language.Lean.process
let snap ← processor (fun _ => pure <| .ok { mainModuleName, opts, trustLevel, plugins }) none ctx
Expand Down
Loading