Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow turnstiles anywhere in location sequences #6992

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrr6
Copy link
Contributor

@jrr6 jrr6 commented Feb 7, 2025

This PR changes the syntax of location modifiers for tactics like simp and rw (e.g., simp at h ⊢) to allow the turnstile to appear anywhere in the sequence of locations.

Closes #2278.

@jrr6 jrr6 added changes-stage0 Contains stage0 changes, merge manually using rebase changelog-language Language features, tactics, and metaprograms labels Feb 7, 2025
@jrr6 jrr6 requested a review from kim-em as a code owner February 7, 2025 17:00
@jrr6 jrr6 force-pushed the location-turnstile branch from 1533488 to e0186ee Compare February 7, 2025 23:16
@jrr6 jrr6 force-pushed the location-turnstile branch from e0186ee to 8740174 Compare February 8, 2025 17:20
@nomeata
Copy link
Collaborator

nomeata commented Feb 8, 2025

Are you sure this PR doesn't work without stage0 update? Have you played with the preferNative flag, or the parseQuotWithCurrentStage?

@jrr6
Copy link
Contributor Author

jrr6 commented Feb 8, 2025

Are you sure this PR doesn't work without stage0 update? Have you played with the preferNative flag, or the parseQuotWithCurrentStage?

No matter what permutation of those two flags I use, if I don't do the intermediate stage0 update, I get the following error at a simp … at h ⊢ invocation in core:

Init/Data/String/Basic.lean:738:51: error: elaboration function for 'Lean.Parser.Tactic.locationTurnstile' has not been implemented

It seems as though the syntax change registers, but it's still using the built-in elaboration function from the old stage0, which is expecting the old syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-language Language features, tactics, and metaprograms changes-stage0 Contains stage0 changes, merge manually using rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support at ⊢ h as a Location
2 participants