No explicit header set for the DOWNLOAD_SESSION #483 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ads a resource from a specified URL while including a custom User-Agent header for identification. It constructs the User-Agent string using the application's version and the user's email, sends an authenticated GET request to the URL, and saves the downloaded content to a file if the request is successful. The script also includes an example usage section where the user can specify their email, API token, and download URL.
rtibbles
reviewed
Nov 8, 2024
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| import requests | |||
| from requests_file import FileAdapter | |||
| from . import ricecooker # Import to access the version | |||
| from .auth import get_user_email # Assuming you have a function to get the user's email | |||
rtibbles
reviewed
Nov 8, 2024
| # Set User-Agent header for DOWNLOAD_SESSION | ||
| user_email = authenticate_user(token)[0] # Get the user's email | ||
| config.DOWNLOAD_SESSION.headers.update({ | ||
| "User-Agent": f"Ricecooker/{ricecooker.__version__} bot ({user_email})" |
There was a problem hiding this comment.
Is the username not the user_email in this case?
rtibbles
requested changes
Nov 8, 2024
There was a problem hiding this comment.
I think the change in commands.py is all that is needed.
This rather has the appearance of having been automatically generated by a generative AI, as some of the code here refers to non-existent modules.
Please before submitting a pull request, test that your code actually works and doesn't break things.
| @@ -94,6 +96,12 @@ def uploadchannel( # noqa: C901 | |||
| username = "" | |||
| token = "" | |||
|
|
|||
| # Set User-Agent header for DOWNLOAD_SESSION | |||
| user_email = authenticate_user(token)[0] # Get the user's email | |||
There was a problem hiding this comment.
Not sure why we need to reauthenticate here, we already got the username above.
|
Ok ,sure i will correct them. |
Repository owner
closed this by deleting the head repository
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ads a resource from a specified URL while including a custom User-Agent header for identification. It constructs the User-Agent string using the application's version and the user's email, sends an authenticated GET request to the URL, and saves the downloaded content to a file if the request is successful. The script also includes an example usage section where the user can specify their email, API token, and download URL.