Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer link existing item #720

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Explorer link existing item #720

wants to merge 8 commits into from

Conversation

evoiron
Copy link
Collaborator

@evoiron evoiron commented Jan 24, 2025

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel 
     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

@evoiron evoiron marked this pull request as draft January 24, 2025 14:50
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from daaeaeb to 6135dd7 Compare January 30, 2025 10:00
@evoiron evoiron marked this pull request as ready for review January 31, 2025 09:37
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from 6135dd7 to 1f2907f Compare January 31, 2025 09:47
P0ppoff
P0ppoff requested changes Jan 31, 2025
View reviewed changes
apps/data-studio/src/components/LibraryHome/LibraryHome.tsx Outdated Show resolved Hide resolved
libs/ui/src/_gqlTypes/index.ts Show resolved Hide resolved
libs/ui/src/components/Explorer/DataView.tsx Show resolved Hide resolved
libs/ui/src/components/Explorer/usePrimaryActions.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/useAddLinkMassAction.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from 1f2907f to 350c619 Compare February 3, 2025 09:51
@evoiron evoiron requested a review from P0ppoff February 3, 2025 09:52
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from 350c619 to 6143c43 Compare February 3, 2025 14:43
P0ppoff
P0ppoff reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@P0ppoff P0ppoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut que l'on s'appelle, je te propose de faire un call après manger

libs/ui/src/_gqlTypes/index.ts Show resolved Hide resolved
libs/ui/src/components/Explorer/Explorer.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/Explorer.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/Explorer.tsx Show resolved Hide resolved
libs/ui/src/components/Explorer/useAddLinkMassAction.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/link-item/AddLinkModal.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/Explorer.test.tsx Outdated Show resolved Hide resolved
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from 99eec12 to 089144c Compare February 4, 2025 14:35
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from 089144c to 0e20025 Compare February 4, 2025 15:31
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch 2 times, most recently from 813fbd6 to 440f2dd Compare February 5, 2025 08:47
@evoiron evoiron force-pushed the feature/XSTREAM-1093_addExistingElement branch from 440f2dd to 6454809 Compare February 7, 2025 08:28
@P0ppoff P0ppoff force-pushed the feature/XSTREAM-1093_addExistingElement branch from 6454809 to 27cb7d9 Compare February 7, 2025 14:02
@P0ppoff P0ppoff force-pushed the feature/XSTREAM-1093_addExistingElement branch 2 times, most recently from bf4cb92 to 869792b Compare February 7, 2025 14:33
@P0ppoff P0ppoff force-pushed the feature/XSTREAM-1093_addExistingElement branch from 869792b to c037455 Compare February 7, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P0ppoff P0ppoff P0ppoff approved these changes

@NicoSourimant NicoSourimant NicoSourimant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evoiron @P0ppoff @NicoSourimant