Func-y scripts #87
Merged
Func-y scripts #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gipert
reviewed
Feb 4, 2025
gipert
reviewed
Feb 4, 2025
gipert
reviewed
Feb 4, 2025
| else: | ||
| fk.channel = channel | ||
| return fk.get_path_from_filekey(get_pattern_log_channel(self.setup, name))[0] | ||
| return "/tmp/log.log" |
gipert
reviewed
Feb 4, 2025
| ) | ||
| argparser.add_argument("--output", help="output file", type=str, required=True) | ||
| argparser.add_argument( | ||
| "--in_db", |
There was a problem hiding this comment.
Suggested change
| "--in_db", | |
| "--in-db", |
One general comment: we should only use dashes in command line options. ArgParser automatically promotes them to underscores.
gipert
reviewed
Feb 4, 2025
gipert
reviewed
Feb 4, 2025
gipert
reviewed
Feb 4, 2025
| @@ -60,19 +60,19 @@ def execenv_python(config, aslist=False): | |||
| return " ".join(cmdline), cmdenv | |||
|
|
|||
|
|
|||
| def execenv_smk_py_script(workflow, config, scriptname, aslist=False): | |||
| def execenv_smk_py_script(config, scriptname, aslist=False): | |||
There was a problem hiding this comment.
should we rename this to execenv_smk_pyexe()...?
gipert
reviewed
Feb 4, 2025
| @@ -84,14 +84,43 @@ docs = [ | |||
|
|
|||
| [project.scripts] | |||
| dataprod = "legenddataflow.execenv:dataprod" | |||
| create_chankeylist = "legenddataflow.scripts.create_chankeylist:create_chankeylist" | |||
There was a problem hiding this comment.
I prefer using dashes in command lines (see similar comment about command line options).
There was a problem hiding this comment.
sure maybe add as an issue and can get to it sometime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.