Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(info): track gpud process self resource usage (file descriptors, RSS, start time, db size) #296

Merged
merged 1 commit into from
Jan 18, 2025
Merged

feat(info): track gpud process self resource usage (file descriptors, RSS, start time, db size) #296

merged 1 commit into from
Jan 18, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 15, 2025

No description provided.

@gyuho gyuho self-assigned this Jan 15, 2025
@gyuho gyuho changed the title feat(info): track gpud process self resource usage (file descriptors, RSS, start time) feat(info): track gpud process self resource usage (file descriptors, RSS, start time, db size) Jan 16, 2025
@gyuho gyuho force-pushed the fd-usage-gpud branch 3 times, most recently from affa1db to 6cf49af Compare January 17, 2025 13:05
@xiang90
Copy link
Contributor

xiang90 commented Jan 17, 2025

let us some tests

@gyuho
Copy link
Collaborator Author

gyuho commented Jan 18, 2025

@cardyok @xiang90 Unit tested and end-to-end tested in our machine:

    "component": "info",
    "states": [
      {
        "name": "daemon",
        "healthy": true,
        "reason": "daemon version: v0.3.7, mac address: 74:50:4e:d3:48:98",
        "extra_info": {
          "daemon_version": "v0.3.7",
          "gpud_pid": "2770292",
          "gpud_start_time_humanized": "20 hours ago",
          "gpud_start_time_in_unix_time": "1737112931",
          "gpud_usage_db_humanized": "10 MB",
          "gpud_usage_db_in_bytes": "10244096",
          "gpud_usage_file_descriptors": "833",
          "gpud_usage_memory_humanized": "350 MB",
          "gpud_usage_memory_in_bytes": "350175232",
          "mac_address": "74:50:4e:d3:48:98",
          "packages": "null"
        }
      },

@xiang90
Copy link
Contributor

xiang90 commented Jan 18, 2025

defer to @cardyok or @eahydra

eahydra
eahydra approved these changes Jan 18, 2025
View reviewed changes
cardyok
cardyok approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@cardyok cardyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit c74fbab into main Jan 18, 2025
4 checks passed
@gyuho gyuho deleted the fd-usage-gpud branch January 18, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiang90 xiang90 xiang90 left review comments

@eahydra eahydra eahydra approved these changes

@cardyok cardyok cardyok approved these changes

Assignees

@gyuho gyuho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @xiang90 @eahydra @cardyok