Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailscale): remove unused version checks #299

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 16, 2025

No description provided.

@gyuho gyuho self-assigned this Jan 16, 2025
@gyuho gyuho force-pushed the bumpup-tailscale-version-timeouts branch 2 times, most recently from a445c70 to d796290 Compare January 16, 2025 09:07
@gyuho gyuho changed the title fix(tailscale): make version checks less flaky with retries fix(tailscale): make version checks less flaky with retries, fallback to previous version Jan 16, 2025
@xiang90
Copy link
Contributor

xiang90 commented Jan 17, 2025

this is way too complicated than needed. what is the problem that we are trying to solve?

@gyuho gyuho added the wip - do not merge working in progress label Jan 18, 2025
@gyuho gyuho changed the title fix(tailscale): make version checks less flaky with retries, fallback to previous version fix(tailscale): remove unused version checks Jan 18, 2025
@gyuho gyuho force-pushed the bumpup-tailscale-version-timeouts branch from d796290 to 3b39fab Compare January 18, 2025 15:43
@xiang90
Copy link
Contributor

xiang90 commented Jan 19, 2025

do we check the systemd unit status?

@xiang90
Copy link
Contributor

xiang90 commented Jan 19, 2025

ok. let us get rid of the version check first anyway. it is not useful. let us create a new pr to check tailscale status.

@gyuho gyuho force-pushed the bumpup-tailscale-version-timeouts branch from 3b39fab to 4c18784 Compare January 19, 2025 11:32
@gyuho gyuho removed the wip - do not merge working in progress label Jan 19, 2025
@gyuho gyuho added this to the v0.4.0 milestone Jan 19, 2025
@gyuho
Copy link
Collaborator Author

gyuho commented Jan 19, 2025

@xiang90 @cardyok Updated. And actually, we do check tailscale systemd status:

gpud/config/default.go

Lines 189 to 191 in a7cdf53

if active, err := pkd_systemd.IsActive("tailscaled"); err == nil && active {
systemdCfg.Units = append(systemdCfg.Units, "tailscaled")
}

(assume, tailscaled is already running or enabled after gpud join)

@gyuho gyuho force-pushed the bumpup-tailscale-version-timeouts branch 3 times, most recently from 88e2125 to dd2e7bf Compare January 21, 2025 10:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 21.10%. Comparing base (88e73d8) to head (13439a2).

Files with missing lines Patch % Lines
components/tailscale/component.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   21.04%   21.10%   +0.06%     
==========================================
  Files         299      298       -1     
  Lines       26872    26737     -135     
==========================================
- Hits         5655     5643      -12     
+ Misses      20551    20428     -123     
  Partials      666      666              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho force-pushed the bumpup-tailscale-version-timeouts branch 2 times, most recently from 58950d6 to 2e56563 Compare January 21, 2025 14:29
@gyuho gyuho force-pushed the bumpup-tailscale-version-timeouts branch from 2e56563 to 13439a2 Compare January 21, 2025 15:21
@gyuho gyuho merged commit 1ca5660 into main Jan 21, 2025
4 checks passed
@gyuho gyuho deleted the bumpup-tailscale-version-timeouts branch January 21, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants