-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tailscale): remove unused version checks #299
Conversation
a445c70
to
d796290
Compare
this is way too complicated than needed. what is the problem that we are trying to solve? |
d796290
to
3b39fab
Compare
do we check the systemd unit status? |
ok. let us get rid of the version check first anyway. it is not useful. let us create a new pr to check tailscale status. |
3b39fab
to
4c18784
Compare
@xiang90 @cardyok Updated. And actually, we do check tailscale systemd status: Lines 189 to 191 in a7cdf53
(assume, tailscaled is already running or enabled after gpud join) |
88e2125
to
dd2e7bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 21.04% 21.10% +0.06%
==========================================
Files 299 298 -1
Lines 26872 26737 -135
==========================================
- Hits 5655 5643 -12
+ Misses 20551 20428 -123
Partials 666 666 ☔ View full report in Codecov by Sentry. |
58950d6
to
2e56563
Compare
Signed-off-by: Gyuho Lee <[email protected]>
2e56563
to
13439a2
Compare
No description provided.