Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nvidia/ib): remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility #308

Merged
merged 3 commits into from
Jan 22, 2025
Merged

feat(nvidia/ib): remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility #308

merged 3 commits into from
Jan 22, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 20, 2025 •
edited
Loading

  • remove gpud run --expected-port-states-nvidia-infiniband flag
  • still keep the default ports/rates detection

@gyuho gyuho self-assigned this Jan 20, 2025
@gyuho gyuho added this to the v0.4.0 milestone Jan 20, 2025
@gyuho gyuho changed the title fix(nvidia/ib): if nothing specified, skip ib check fix(nvidia/ib): if nothing specified, skip ib check, WE DO NOT AUTO-DETECT or AUTO-COUNT IB DEVICES ANYMORE Jan 20, 2025
@gyuho gyuho force-pushed the ib-check-skips branch 2 times, most recently from 251222a to ffc3183 Compare January 21, 2025 10:09
@gyuho gyuho added the wip - do not merge working in progress label Jan 21, 2025
@gyuho gyuho changed the title fix(nvidia/ib): if nothing specified, skip ib check, WE DO NOT AUTO-DETECT or AUTO-COUNT IB DEVICES ANYMORE fix(nvidia/ib): if nothing specified, skip ib check, remove "gpud run --expected-port-states-nvidia-infiniband" flag, WE DO NOT AUTO-DETECT or AUTO-COUNT IB DEVICES ANYMORE Jan 21, 2025
@gyuho gyuho changed the title fix(nvidia/ib): if nothing specified, skip ib check, remove "gpud run --expected-port-states-nvidia-infiniband" flag, WE DO NOT AUTO-DETECT or AUTO-COUNT IB DEVICES ANYMORE fix(nvidia/ib): if nothing specified, skip ib check, remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility Jan 21, 2025
@gyuho gyuho changed the title fix(nvidia/ib): if nothing specified, skip ib check, remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility fix(nvidia/ib): remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility Jan 21, 2025
@leptonai leptonai deleted a comment from codecov-commenter Jan 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 21.13%. Comparing base (1ca5660) to head (c13a453).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../accelerator/nvidia/infiniband/component_output.go 48.38% 14 Missing and 2 partials ⚠️
components/accelerator/nvidia/infiniband/config.go 0.00% 8 Missing ⚠️
internal/server/server.go 0.00% 2 Missing ⚠️
...ponents/accelerator/nvidia/infiniband/component.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   20.72%   21.13%   +0.40%     
==========================================
  Files         298      298              
  Lines       26737    26726      -11     
==========================================
+ Hits         5542     5649     +107     
+ Misses      20541    20411     -130     
- Partials      654      666      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho removed the wip - do not merge working in progress label Jan 21, 2025
@gyuho gyuho changed the title fix(nvidia/ib): remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility feat(nvidia/ib): remove "gpud run --expected-port-states-nvidia-infiniband" flag, only keep the default detection for backward compatibility Jan 21, 2025
@gyuho
feat(nvidia/ib): remove "gpud run --expected-port-states-nvidia-infin…
521ca67 
…iband" flag, only keep the default detection for backward compatibility

Signed-off-by: Gyuho Lee <[email protected]>
FillZpp
FillZpp approved these changes Jan 22, 2025
View reviewed changes
gyuho added 2 commits January 22, 2025 13:24
@gyuho
change msg
2c6ec3c 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
better issue msg
c13a453 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho merged commit 3a3a77b into main Jan 22, 2025
4 checks passed
@gyuho gyuho deleted the ib-check-skips branch January 22, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccding ccding ccding left review comments

@FillZpp FillZpp FillZpp approved these changes

Assignees

@gyuho gyuho

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @codecov-commenter @ccding @FillZpp