-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nvidia): configurable nvidia-smi binary, ibstat binary, infiniband class dir paths for mock testing #310
Conversation
gyuho
commented
Jan 20, 2025
•
edited
Loading
edited
868722c
to
ef503cd
Compare
e077620
to
c123863
Compare
c123863
to
37b3f64
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 20.71% 21.01% +0.29%
==========================================
Files 318 300 -18
Lines 26900 26926 +26
==========================================
+ Hits 5572 5658 +86
+ Misses 20677 20604 -73
- Partials 651 664 +13 ☔ View full report in Codecov by Sentry. |
6da0c79
to
783c5be
Compare
NvidiaSMICommand string `json:"nvidia_smi_command"` | ||
NvidiaSMIQueryCommand string `json:"nvidia_smi_query_command"` | ||
IbstatCommand string `json:"ibstat_command"` | ||
InfinibandClassDirectory string `json:"infiniband_class_directory"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are passing these everywhere. can we use an embedded struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccding Addressed, PTAL. Thanks.
a3a0e61
to
ec3b046
Compare
b05dcda
to
61f548c
Compare
…nd class dir paths for mock testing Signed-off-by: Gyuho Lee <[email protected]>
61f548c
to
634c0b9
Compare
Signed-off-by: Gyuho Lee <[email protected]>
Will merge after end-to-end tests |
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>