chore(ci): merge codecov workflow files #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoshi01
requested review from
cardyok and
eahydra
and removed request for
cardyok
eahydra
changed the title
eahydra
changed the title
eahydra
reviewed
Jan 20, 2025
scripts/tests-unit.sh
Outdated
| @@ -19,3 +23,20 @@ go fmt ./... | |||
| go vet -v ./... | |||
| go test -v ./... | |||
| go test -v -race ./... | |||
|
|
|||
| echo "=== Running tests and generating coverage report ===" | |||
| go test -coverprofile="${COVERAGE_FILE}" ./... 2>&1 | tee "${LOG_FILE}" | |||
There was a problem hiding this comment.
We should replace line 24 and make sure line 25 continues to work. BTW: I think we can merge line 24 with line 25? /cc @gyuho
Suggested change
| go test -coverprofile="${COVERAGE_FILE}" ./... 2>&1 | tee "${LOG_FILE}" | |
| go test -v -coverprofile="${COVERAGE_FILE}" ./... |
scripts/tests-unit.sh
Outdated
| @@ -19,3 +23,20 @@ go fmt ./... | |||
| go vet -v ./... | |||
| go test -v ./... | |||
| go test -v -race ./... | |||
|
|
|||
| echo "=== Running tests and generating coverage report ===" | |||
There was a problem hiding this comment.
Suggested change
| echo "=== Running tests and generating coverage report ===" |
scripts/tests-unit.sh
Outdated
| exit $test_success | ||
| fi | ||
|
|
||
| echo "=== Checking if coverage file exists ===" |
There was a problem hiding this comment.
Suggested change
| echo "=== Checking if coverage file exists ===" |
scripts/tests-unit.sh
Outdated
| @@ -10,6 +10,10 @@ set -o nounset | |||
| # exit script whenever it errs | |||
| set -o errexit | |||
|
|
|||
| LOG_FILE=${1:-test-coverage.log} | |||
There was a problem hiding this comment.
Suggested change
| LOG_FILE=${1:-test-coverage.log} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.