Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnose): fix "gpud scan" (add missing temp db creation) #314

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 20, 2025

No description provided.

@gyuho gyuho self-assigned this Jan 20, 2025
@gyuho gyuho added this to the v0.4.0 milestone Jan 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 20.05%. Comparing base (cd89e72) to head (8851f67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
components/diagnose/scan.go 0.00% 47 Missing and 1 partial ⚠️
cmd/gpud/command/command.go 0.00% 5 Missing ⚠️
components/diagnose/options.go 0.00% 4 Missing ⚠️
cmd/gpud/command/scan.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   19.94%   20.05%   +0.11%     
==========================================
  Files         316      316              
  Lines       26531    26548      +17     
==========================================
+ Hits         5292     5325      +33     
+ Misses      20619    20588      -31     
- Partials      620      635      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiang90
Copy link
Contributor

xiang90 commented Jan 20, 2025

test?

gyuho added 3 commits January 20, 2025 23:20
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
Copy link
Collaborator Author

gyuho commented Jan 20, 2025

@xiang90 Now running gpud scan on each e2e test runs. Also, manually tested in GPU machines.

@xiang90
Copy link
Contributor

xiang90 commented Jan 20, 2025

can we also add some unit test?

@ccding
Copy link

ccding commented Jan 21, 2025

lgtm after adding tests

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho merged commit 8af22e8 into main Jan 21, 2025
5 checks passed
@gyuho gyuho deleted the fix-gpud-scan branch January 21, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants