Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from lint.Lint to lint.CertificateLint #7230

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Switch from lint.Lint to lint.CertificateLint #7230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16b4a6c
Switch from lint.Lint ot lint.CertificateLint
mcpherrinm Dec 20, 2023
bd5dc3e
lint.LintInterface to lint.CertificateLintInterface
mcpherrinm Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions linter/lints/chrome/e_scts_from_same_operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,19 @@ type sctsFromSameOperator struct {
}

func init() {
lint.RegisterLint(&lint.Lint{
Name: "e_scts_from_same_operator",
Description: "Let's Encrypt Subscriber Certificates have two SCTs from logs run by different operators",
Citation: "Chrome CT Policy",
Source: lints.ChromeCTPolicy,
EffectiveDate: time.Date(2022, time.April, 15, 0, 0, 0, 0, time.UTC),
Lint: NewSCTsFromSameOperator,
lint.RegisterCertificateLint(&lint.CertificateLint{
LintMetadata: lint.LintMetadata{
Name: "e_scts_from_same_operator",
Description: "Let's Encrypt Subscriber Certificates have two SCTs from logs run by different operators",
Citation: "Chrome CT Policy",
Source: lints.ChromeCTPolicy,
EffectiveDate: time.Date(2022, time.April, 15, 0, 0, 0, 0, time.UTC),
},
Lint: NewSCTsFromSameOperator,
})
}

func NewSCTsFromSameOperator() lint.LintInterface {
func NewSCTsFromSameOperator() lint.CertificateLintInterface {
return &sctsFromSameOperator{logList: loglist.GetLintList()}
}

Expand Down
18 changes: 10 additions & 8 deletions linter/lints/cpcps/lint_root_ca_cert_validity_period_greater_than_25_years.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,19 @@ import (
type rootCACertValidityTooLong struct{}

func init() {
lint.RegisterLint(&lint.Lint{
Name: "e_root_ca_cert_validity_period_greater_than_25_years",
Description: "Let's Encrypt Root CA Certificates have Validity Periods of up to 25 years",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
Lint: NewRootCACertValidityTooLong,
lint.RegisterCertificateLint(&lint.CertificateLint{
LintMetadata: lint.LintMetadata{
Name: "e_root_ca_cert_validity_period_greater_than_25_years",
Description: "Let's Encrypt Root CA Certificates have Validity Periods of up to 25 years",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
},
Lint: NewRootCACertValidityTooLong,
})
}

func NewRootCACertValidityTooLong() lint.LintInterface {
func NewRootCACertValidityTooLong() lint.CertificateLintInterface {
return &rootCACertValidityTooLong{}
}

Expand Down
18 changes: 10 additions & 8 deletions linter/lints/cpcps/lint_subordinate_ca_cert_validity_period_greater_than_8_years.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,19 @@ import (
type subordinateCACertValidityTooLong struct{}

func init() {
lint.RegisterLint(&lint.Lint{
Name: "e_validity_period_greater_than_8_years",
Description: "Let's Encrypt Intermediate CA Certificates have Validity Periods of up to 8 years",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
Lint: NewSubordinateCACertValidityTooLong,
lint.RegisterCertificateLint(&lint.CertificateLint{
LintMetadata: lint.LintMetadata{
Name: "e_validity_period_greater_than_8_years",
Description: "Let's Encrypt Intermediate CA Certificates have Validity Periods of up to 8 years",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
},
Lint: NewSubordinateCACertValidityTooLong,
})
}

func NewSubordinateCACertValidityTooLong() lint.LintInterface {
func NewSubordinateCACertValidityTooLong() lint.CertificateLintInterface {
return &subordinateCACertValidityTooLong{}
}

Expand Down
18 changes: 10 additions & 8 deletions linter/lints/cpcps/lint_subscriber_cert_validity_greater_than_100_days.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,19 @@ import (
type subscriberCertValidityTooLong struct{}

func init() {
lint.RegisterLint(&lint.Lint{
Name: "e_subscriber_cert_validity_period_greater_than_100_days",
Description: "Let's Encrypt Subscriber Certificates have Validity Periods of up to 100 days",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
Lint: NewSubscriberCertValidityTooLong,
lint.RegisterCertificateLint(&lint.CertificateLint{
LintMetadata: lint.LintMetadata{
Name: "e_subscriber_cert_validity_period_greater_than_100_days",
Description: "Let's Encrypt Subscriber Certificates have Validity Periods of up to 100 days",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
},
Lint: NewSubscriberCertValidityTooLong,
})
}

func NewSubscriberCertValidityTooLong() lint.LintInterface {
func NewSubscriberCertValidityTooLong() lint.CertificateLintInterface {
return &subscriberCertValidityTooLong{}
}

Expand Down
18 changes: 10 additions & 8 deletions linter/lints/cpcps/lint_validity_period_has_extra_second.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,19 @@ import (
type certValidityNotRound struct{}

func init() {
lint.RegisterLint(&lint.Lint{
Name: "w_validity_period_has_extra_second",
Description: "Let's Encrypt Certificates have Validity Periods that are a round number of seconds",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
Lint: NewCertValidityNotRound,
lint.RegisterCertificateLint(&lint.CertificateLint{
LintMetadata: lint.LintMetadata{
Name: "w_validity_period_has_extra_second",
Description: "Let's Encrypt Certificates have Validity Periods that are a round number of seconds",
Citation: "CPS: 7.1",
Source: lints.LetsEncryptCPS,
EffectiveDate: lints.CPSV33Date,
},
Lint: NewCertValidityNotRound,
})
}

func NewCertValidityNotRound() lint.LintInterface {
func NewCertValidityNotRound() lint.CertificateLintInterface {
return &certValidityNotRound{}
}

Expand Down