Fix federated ZDC detection algorithm #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
approved these changes
Mar 7, 2025
edwardalee
deleted the
2475-deadlock-was-occurred-with-hierarchical-reactor
branch
|
Thank you so much @erlingrj, for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @byeonggiljun for debugging this. There was a bug in the ZDC detection algorithm where a node is added to the set of visited when we have a delayed connection to it. This made us skip this node later when we had an actual zero-delay connection. The fix is to only add nodes that you actually visit to the visited set.
Fixes #2475