Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Classification example #107

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

vinzbarbuto
Copy link
Collaborator

Here are the files that demonstrate the Audio Classification example, complete with an installation and execution guide.

@lhstrh
Copy link
Member

lhstrh commented Apr 10, 2024

This looks really cool, but I want to caution against checking large binary files into git. A possible alternative would be to use https://git-lfs.com/.

@vinzbarbuto
Copy link
Collaborator Author

Indeed, the binary file comprises the Tensorflow Lite model. How would you recommend handling it?

@lhstrh
Copy link
Member

lhstrh commented Apr 10, 2024

Indeed, the binary file comprises the Tensorflow Lite model. How would you recommend handling it?

I would suggest Git LFS.

@vinzbarbuto
Copy link
Collaborator Author

Thanks @lhstrh , I will look into it

@lhstrh
Copy link
Member

lhstrh commented Apr 10, 2024

Thanks for trying out LFS! Note that 6d34a57 has deposited the file into the history already, so that commit would have to be rewritten before this PR gets merged.

@vinzbarbuto vinzbarbuto force-pushed the vinzbarbuto-audioclassification-v1 branch from 1481796 to 7aac7ea Compare April 11, 2024 00:10
@vinzbarbuto vinzbarbuto force-pushed the vinzbarbuto-audioclassification-v1 branch from 7aac7ea to 865b6ef Compare April 11, 2024 00:38
@lhstrh lhstrh reopened this Apr 11, 2024
@lhstrh lhstrh force-pushed the vinzbarbuto-audioclassification-v1 branch from 8bd0a4b to 8a583f2 Compare May 1, 2024 19:13
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the history and using LFS!

@lhstrh lhstrh merged commit c403c24 into main May 1, 2024
5 checks passed
@lhstrh lhstrh deleted the vinzbarbuto-audioclassification-v1 branch May 1, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants