Fix: Include quest completion timestamp in get_quest_participants response #359
Conversation
TropicalDog17
changed the title
|
Hello @TropicalDog17 when will the PR be ready for review ? |
|
Hey please review this PR. Thank you so much! @Marchand-Nicolas |
src/config.rs
Outdated
| @@ -229,8 +229,10 @@ pub fn load() -> Config { | |||
| let args: Vec<String> = env::args().collect(); | |||
| let config_path = if args.len() <= 1 { | |||
| "config.toml" | |||
| } else { | |||
| } else if (args.len() > 1) && (args.get(1).unwrap().contains("toml")) { | |||
src/tests/endpoints.rs
Outdated
| @@ -26,4 +26,8 @@ pub mod tests { | |||
| let response = client.get(endpoint).send().await.unwrap(); | |||
| assert_eq!(response.status(), StatusCode::OK); | |||
| } | |||
|
|
|||
| // #[tokio::test] | |||
| // pub async fn test_get_quest_participants() { | |||
There was a problem hiding this comment.
You can remove this
| return (StatusCode::OK, Json(res)).into_response(); | ||
| (StatusCode::OK, Json(res)).into_response() | ||
| } | ||
| #[cfg(test)] |
There was a problem hiding this comment.
No need to have the tests, but it was a good idea to make sure everything was working. The problem is that if we run tests in production, it'll reset the db
|
Hello @TropicalDog17 everything good ? |
|
Hi sorry for the delay, can you review @Marchand-Nicolas |
src/config.rs
Outdated
| args.get(1).unwrap() | ||
| } else { |
There was a problem hiding this comment.
No need to have these changes, you can revert
src/tests/endpoints.rs
Outdated
| @@ -26,4 +26,8 @@ pub mod tests { | |||
| let response = client.get(endpoint).send().await.unwrap(); | |||
| assert_eq!(response.status(), StatusCode::OK); | |||
| } | |||
|
|
|||
| // #[tokio::test] | |||
There was a problem hiding this comment.
No need to have these comments
| @@ -99,3 +101,168 @@ pub async fn get_quest_participants_handler( | |||
| let participants_json = json!({ "participants": participants }); | |||
| (StatusCode::OK, Json(participants_json)).into_response() | |||
| } | |||
|
|
|||
| // #[cfg(test)] | |||
There was a problem hiding this comment.
No need to have these comments
| @@ -58,11 +58,13 @@ pub async fn get_quest_participants_handler( | |||
| doc! { "$match": { "task_id": { "$in": &task_ids } } }, | |||
| doc! { "$group": { | |||
| "_id": "$address", | |||
| "task_ids": { "$addToSet": "$task_id" } | |||
| "task_ids": { "$addToSet": "$task_id" }, | |||
| "max_timestamp": { "$max": "$timestamp.$numberLong" } | |||
There was a problem hiding this comment.
Error aggregating completed tasks: Kind: Command failed: Error code 16410 (Location16410): FieldPath field names may not start with '$'. Consider using $getField or $setField., labels: {}
|
Hello @TropicalDog17 everything good ? |
|
Hi @Marchand-Nicolas I struggle to debug this, since I am not quite able to setup the enviroment properly, can you help me? Sorry for any inconvenience |
|
Hello @TropicalDog17 here is a guide to help you setup the project: https://github.com/lfglabs-dev/api.starknet.quest/blob/testnet/README.md |
|
Hello @TropicalDog17 Can I assign someone else ? It's been more than a month |
The pipeline not work i think |
|
@Marchand-Nicolas could you help me test the pipeline, I am able to set up the project and authen the admin route, create new quest. But I am not able to populate some tasks for testing. I think it will be a good idea to has some scripts for populate some mock data for testing. |
You can run the frontend to add tasks https://github.com/lfglabs-dev/starknet.quest/ |
|
You can test your pipeline in Compass |
Close #358