Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some additional ip pool sensors #16946

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Added some additional ip pool sensors #16946

merged 4 commits into from
Jan 14, 2025

Conversation

laf
Copy link
Member

@laf laf commented Jan 6, 2025

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf laf added the Device 🖥️ New or added device support label Jan 6, 2025
@laf laf merged commit 0cabf34 into librenms:master Jan 14, 2025
8 checks passed
@laf laf deleted the flexbng-ip branch January 14, 2025 07:54
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/25-1-0-changelog/26965/1

laf added a commit to Torstein-Eide/librenms that referenced this pull request Jan 18, 2025
@laf
Added some additional ip pool sensors for flexbng (librenms#16946)
8d06860 
* Added some additional ip pool sensors

* Restored deleted files

* Restored test data

* Removed additional test data
mpikzink pushed a commit to mpikzink/librenms that referenced this pull request Jan 19, 2025
@laf @mpikzink
Added some additional ip pool sensors for flexbng (librenms#16946)
82e2b2a 
* Added some additional ip pool sensors

* Restored deleted files

* Restored test data

* Removed additional test data
murrant added a commit that referenced this pull request Jan 21, 2025
@mpikzink @laf
@jakejakejakejakejakejake @Martin22 @PipoCanaja @dko-strd @rinsekloek @JacobErnst98 @Jellyfrog @btriller @takyanagida @slashdoom @murrant @TotalGriffLock @Cameron-84 @Torstein-Eide @gunkaaa
get_device_id_by_port_id(x) => PortCache::get() (#16969)
c5be184 
* get_device_id_by_port_id(x) => Port::where('port_id', x)->value('device_id')

* Update includes/html/functions.inc.php

* Revert to where()

* Rename Jira Service Managment transport file to fix librenms Issue #16195 (#16967)

* get_dev_attribs($device_id) => Use the Model Method (#16961)

* get_dev_attribs($device_id) => Use the Model Method $device->getAttribs()

* Fix StyleCI

* Workaround for SQL Queries

* Added wireless interface to ports for Tachyon (#16867)

* Added wireless interface to ports

* Fix styleci

* Refactored to use SnmpQuery for wireless peer statistics

* Removed unnecessary use statement for SnmpQuery

* Fix TypeError by casting index to int

* Fix styleci

* Fix code

---------

Co-authored-by: PipoCanaja <[email protected]>

* Revert "ifClass() => Url::portLinkDisplayClass() (#16962)" (#16976)

This reverts commit 2658d68.

* Added support for UTAX printers (#16951)

* Add support for UTAX printers

* Updated logos and generated test data

* Updated logos

* Logo update

* Logo update

---------

Co-authored-by: Neil Lathwood <[email protected]>

* Additional type declarations to Eventlog (#16968)

* Additional type declarations to #16965

* Fix StyleCI

* Optional type string

* Nokia ISAM added extra context to also snmpwalk the ihub for uplink ports (#16676)

* Nokia isam ports extra contact ihub for polling (#416)

* Nokia ISAM

* New version with both ihub and nt

* Added extra pon polling options

* Removed PON specific code

* Code style fixes

* Removed some unneeded part for os

* Made polling more easy with ifXentry

* Removed code not used

* Revert deleting

* Revert deleting

---------

Co-authored-by: root <[email protected]>

* No array merge of ports as it kills indexes

* Updated smmp test file

* Code style fixes

* Test data for Nokia-isam

* Cleared old test data

* New testdata

* Update nokia-isam.json New test data

* Update nokia-isam.json operstatus null

* Update nokia-isam.json ports tests

* Update nokia-isam.json IfOctets swap

* New testdata with other config

* Rerun with entity fix

* Update nokia-isam.inc.php copyright code

* Update ports.inc.php remove obsolete line

* SnmpQuery style

* Tab to spaces

* Style

* updated testdata

* updated testdata

* updated testdata

* Code style

* Removed options

---------

Co-authored-by: root <[email protected]>

* Added some additional ip pool sensors for flexbng (#16946)

* Added some additional ip pool sensors

* Restored deleted files

* Restored test data

* Removed additional test data

* Added support for ESPHOME OS (#16571)

* Support for ESPHOME OS

* added esphome_esp8266.json

* mib support

* Removed skip values for heap in mempools

* Update includes/definitions/discovery/esphome.yaml

Co-authored-by: Jellyfrog <[email protected]>

* Some changes and test data re-done

* Updated logo

* Updated test data

* Update logos to remove width/height

* More changes

* Mib definitions

* Another logo update

---------

Co-authored-by: Jellyfrog <[email protected]>
Co-authored-by: Neil Lathwood <[email protected]>

* Remove apt-transport-https installation recommendation from install docs (#16982)

Drop transitional package

* Added time period names: threeday, tenday (#16932)

* Added Horizon Quantum Device Support (#16970)

* Add files via upload

* Update and rename HORIZON-QUANTUM-MIB_1.2.5.mib to DRAGONWAVE-HORIZON-QUANTUM-MIB

* Create horizon-quantum.yaml

* Create HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Create horizon-quantum.yaml

* Create horizon-quantum.php

* Update HorizonQuantum.php

* Update horizon-quantum.php

* Update horizon-quantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update horizon-quantum.php

* Update horizon-quantum.yaml

* Update ports.inc.php

* Update ports.inc.php

* Rename horizon-quantum.php to horizon-quantum.inc.php

* Update horizon-quantum.inc.php

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update HorizonQuantum.php

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update horizon-quantum.yaml

* Update HorizonQuantum.php

* Update horizon-quantum.inc.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Create horizon-quantum.snmprec

* Create horizon-quantum.json

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update horizon-quantum.inc.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update HorizonQuantum.php

* Update horizon-quantum.inc.php

* Update horizon-quantum.json

---------

Co-authored-by: Neil Lathwood <[email protected]>

* Fix SLA incomplete snmpwalk replies (#16939)

* Fix for Cisco Transceivers (#16856)

* Get interface mapping from subentity

Fix for Cisco some IOSXE devices

* Sensor mapping if Transceiver set already

Fix for some Cisco ISRs

* typo

* use entPhysicalIndex everywhere

Instead of a mix with ifIndex that broke Inventory

* style

* Update Cisco.php

* tests, 1st try

* Update ios_2960x.json

* Update iosxe_c9400.json

* corrected snmp variant as well

Forced for now

* tests, should be better now

* remove the forced-snmp code

* Update iosxe_c9800.json

* Update iosxe_c9800.json (manual)

* Update iosxe_c9800.json

* Update iosxe_ir1101.json

* iosxr

* and more

* Update ios_2960x.json

* more

./scripts/save-test-data.php -o iosxr  -d -m os,ports,ports-stack,entity-physical,processors,mempools,vrf,transceivers,sensors,storage,discovery-protocols

* Update iosxe_ir1101.json

* adapt dependencies for transceivers & sensors

* comware missing sensors

* Update nxos_n3k-3064pq.json

* revert dependencies

* Revert comware change

* config_definitions.json

* testsNew

* New config definition

And tests updated

* iosxe added after rebase

* Update iosxe_c9800.json

* array_intersect_assoc for modules

* Update iosxe_isr4321.json

* Comware is back

* c9800 STP timeout issue

* handle poller modules as well

* remove sensors depends from transceivers

* Update OSModulesTest.php

* tests

* tests

* Update OSModulesTest.php

* testChanged

* cleaning

* composer

* orderby (just testing)

* revert tests/OSModulesTest.php as it is now fixed elsewhere

* tests

* tests

* clear and redo   tests/data/iosxe_ir1101.json

* restore the OSModulesTest patch

* fix comware again with order of discovery module corrected

* fix qos test

* revert qos calculation

* Ensure discovery module order when overriding modules

* Update functions.php

---------

Co-authored-by: Tony Murray <[email protected]>
Co-authored-by: Neil Lathwood <[email protected]>

* Added additional voltage sensor for RouterOS (#16979)

* qos test data fix (#16989)

* Fix fs-centec bias thresholds (#16990)

https://community.librenms.org/t/sensor-under-limit-xcvr-bias/26845

* Fix Junos BGP polling (#16988)

* Fix Junos BGP polling
work around a bug in net-snmp where the -X formatting is not correct for junos peers

* whitespace

* retore enum strings

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <[email protected]>

* Dark mode for the new Sensor graphs (#16985)

* Dark mode for Sensor graphs

* Translalate variables to en

* Convert array keys to variables

* Junos non-null fallbacks for columns that are not nullable (#16993)

* Junos non-null fallbacks for columns that are not nullable

* Columns are unsigned

* Update authentication docs (#16996)

* Update authentication docs
level -> roles
remove most references to config.php settings
add a couple missing settings definitions

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <[email protected]>

* procurve handle HPE rebrand (#16897)

* Update procurve.yaml

Update regex following Aruba to HPE Instant On rebrand

* Create procurve_hpe_instanton1960.snmprec

* Rename procurve_hpe_instanton1960.snmprec to procurve_hpe-instanton1960.snmprec

---------

Co-authored-by: Tony Murray <[email protected]>

* Timos MPLS ignore bad rows (#16997)

* Timos MPLS ignore bad rows

* allow empty sapDescription

* Fix time intervals sometimes being wrong (#16995)

* Fix time interval
Add the context of now to the interval to get accurate diffs
fixes: #16690 #16987

* Apply fixes from StyleCI

* remove if

* Move parseAt to new unit test

---------

Co-authored-by: Tony Murray <[email protected]>

* Changelog for 25.1.0

* Bump version to 25.1.0

* Show unused cached snmp queries (#17004)

SnmpQuery only and only when debug is enabled

* Added processors and memory for Viptela (#16983)

* Viptela vendor - Processor and Memory fix

* Added test data and tidied up the yaml files

* CI fix and function removal

* Viptela - Processor and Memory fix

* Removed usage of getHardware

* Updated vedge1000

---------

Co-authored-by: Neil Lathwood <[email protected]>

* Doc application and RRDCached, refactoring and formatting (#16920)

* Doc cleanup of RRDcached

* Refactoring of Application

* Fix image paths and update links in documentation

* Enhance DocsTest to exclude specific paths when checking for missing documentation pages

* Update DocsTest to exclude all subpaths under Extensions/Applications

* Refactoring of Application

* Fix image paths and update links in documentation

* Fixed CI updated PHP-FPM applications doc

* Testing php 8.3.15

* Reverted php change

* Updated IPv6 valid check

* Changed code

---------

Co-authored-by: Neil Lathwood <[email protected]>

* Remove unix agent global usage (#17003)

use array runtime cache instead

* zeropad() => Str::padLeft() (#16960)

* zeropad() -> Str::padLeft()

* Fix StyleCI

* Fix StyleCI

* Fix Lint

* Fix PHP IPv6 reserved handling changes (#17009)

php/php-src#16944

* Added ZenDuty Transport (#16972)

* Added ZenDuty Transport

* Small doc update

* CI fix

* Added additional options and defaults to ZenDuty Transport

* Removed var_dump()

* Remove some unused functions (#17005)

* Remove some unused functions

* Remove include-dir.inc.php

* Rename variable

* Fix Bug

* Updated Grafana transport and docs to support richer information (#16978)

* Updated Grafana transport and docs to support richer information

* Updated example text to show how to override values

* Updated docs

* Updated docs

* /ZenDuty/Grafana/

* Improve logging for use of values from SNMP;  improve logging for determining multiplier/divisor from YAML (#16949)

* add debug logging for YamlDiscovery::replaceValues() and YamlDiscovery::getValueFromData()

* determine value only once in YamlDiscovery to make PHPStan happy

* syntax to make StyleCI happy

* fix header munged by CI

* add debug logging for YamlDiscovery::replaceValues() and YamlDiscovery::getValueFromData()

* determine value only once in YamlDiscovery to make PHPStan happy

* syntax to make StyleCI happy

* fix header munged by CI

* Log:: instead of \Log::

* remove useless else in replaceValues

* show correct keys used

* simplify multiplier/divisor discovery

* Log:: instead of \Log::

* remove useless else in replaceValues

* show correct keys used

* simplify multiplier/divisor discovery

* syntax

* Implement PortCache (#17002)

* Implement PortCache

* Update references, add ifName and IP maps

* Apply fixes from StyleCI

* Fix if primary is not set, add device to Xdsl calls

* Lint fixes

* Fix up getIdFromIp

* Apply fixes from StyleCI

* Lint fixes

* type fix

* IfIndex from snmp is usually a string, cast inside function

---------

Co-authored-by: Tony Murray <[email protected]>

* Convert timos to SnmpQuery (#17006)

* Convert timos to SnmpQuery

* fix up bgp

* many fixes

* Apply fixes from StyleCI

* isset for wireless sensors

* Missed a filter

---------

Co-authored-by: Tony Murray <[email protected]>

* Use the new PortCache Fassade

* Fix git merge mistake

* Update includes/html/functions.inc.php

---------

Co-authored-by: Neil Lathwood <[email protected]>
Co-authored-by: Jacob Johnson <[email protected]>
Co-authored-by: Martin22 <[email protected]>
Co-authored-by: PipoCanaja <[email protected]>
Co-authored-by: Daniel Köhler <[email protected]>
Co-authored-by: Rinse Kloek <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: Jacob Ernst <[email protected]>
Co-authored-by: Jellyfrog <[email protected]>
Co-authored-by: Bastian Triller <[email protected]>
Co-authored-by: Tak Yanagida <[email protected]>
Co-authored-by: Slashdoom <[email protected]>
Co-authored-by: Tony Murray <[email protected]>
Co-authored-by: Tony Murray <[email protected]>
Co-authored-by: TotalGriffLock <[email protected]>
Co-authored-by: Cameron-84 <[email protected]>
Co-authored-by: Torstein Eide <[email protected]>
Co-authored-by: Guy Lowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Device 🖥️ New or added device support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laf @librenms-bot