lewton: handle OggError(NoCapturePatternFound)

[awiouy]

This fixes #88
I could not find a way to distinguish NoCapturePatternFound without adding ogg

[sashahilton00]

Yup, not possible without ogg package, tried earlier. Thanks for sorting this

[awiouy]

@est31 could you expose NoCapturePattern in lewton, so that we do not need to add ogg to handle it

[est31]

@awiouy great idea, will do!

[est31]

@awiouy see the 0.8.0 update of lewton, it includes a commit to expose the OggReadError enum.

[sashahilton00]

@est31 doesn't it need to be pub use ogg::reading::OggReadError?

[est31]

@sashahilton00 I've done a reexport here, not sure what you mean: https://docs.rs/lewton/0.8.0/src/lewton/lib.rs.html#97

[sashahilton00]

@est31 apologies, should have phrased it better; it was intended as a question as opposed to correction, the reason for which is that I had a look at Anton's code then the ogg docs here: https://docs.rs/ogg/0.5.0/ogg/ and noticed that in Anton's code it was ogg::reading::OggReadError whilst in the docs it did not look like ogg::OggReadError is implemented, but that ogg::reading::OggReadError is, hence I am wondering how the re-export in lewton works, given that ogg::OggReadError doesn't look to be implemented by the ogg crate?

[plietar]

The ogg crate already reexports ogg::reading::OggReadError as ogg::OggReadError in https://docs.rs/ogg/0.5.1/src/ogg/lib.rs.html#37

[sashahilton00]

Got it, thanks for clarifying. Was just me being thick and not interpreting the docs correctly.

[est31]

Yes, there is a two layered export. Sadly it doesn't really show up as reexport in the lewton docs, but like a native enum of the lewton crate: https://docs.rs/lewton/0.8.0/lewton/

I've pushed a commit to fix this. The next version of lewton will display it as pub use.

[awiouy]

Rebased (against current master) to use lewton 0.8.0
lewton 0.8.0 requires Rust 1.20.0

We have two options:

1. Require Rust 1.18.0 and use e87b1f8
2. Require Rust 1.20.0 and use 99e7da5

I prefer option 2 (simpler fix, moving forward).

[sashahilton00]

I would also rather update to 1.20.0 instead of pulling in more dependencies, though I have no idea how many people are on 1.18. Should ask in gitter. Anyone, please weigh in if you have a view.

[sashahilton00]

I'm going to leave this here for a day or so, so that anyone concerned about the version bump has the chance to weigh in. Also note to self: remember to update wiki if necessary.

[plietar]

I'm fine with 1.20.0. That's 3 version behind latest stable, which is enough IMO.