Update softmixer.rs to use AtomicU64 from atomic_shim, so that librespot works with MIPS and MIPSEL #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AtomicU64 from atomic_shim, so that librespot works with MIPS and MIPSEL
|
Would you be so kind to fix the compilation issues? |
Added atomic-shim dependency
Added atomic-shim package
|
Hi, sorry for the back and forth -- I am new to rust. All should be fixed now. |
|
No probs, everyone starts at some point :). Just try to check next time that at least it compiles before submitting a PR^^; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIPS and MIPSEL [and PowerPC (?)] don't support AtomicU64, since they are 32 bit. However, there is a crate that provides shims for these platforms. When it detects it is running on unsupported platforms, it fallbacks to the shim implementation, using crossbeam Mutex. For supported platforms, there should be no change.
See initial discussion in #1460