Fix loading roms larger than 64MB

[thundertheidiot]

This one character fix makes the core able to load roms that are larger than 64MB in size. For example Super Mario 64 romhacks made using the older tools can sometimes surpass 64MB, and mupen64plus_next isn't able to run them correctly without this fix.

[m4xw]

I do have a hard time believing this is all thats required

[thundertheidiot]

Go ahead and try it out. This one romhack called b3313 surpasses 64MB on 0.9 and later versions, and this build fixes it.

[m4xw]

I dont need to try it, at best this will allow data access and maybe interpreter but i am positive code execution from that will fail

[soup6020]

mupen64plus/mupen64plus-core#997
https://benedani.xyz/files/mupen/readme.html
more information about this, not sure who the original author of the latter page is though

[Chlorobyte-but-real]

I dont need to try it, at best this will allow data access and maybe interpreter but i am positive code execution from that will fail

On N64, code isn't ever executed from the ROM. The only ROM accesses are DMA copies to RAM. This makes no change to the RAM layout, it only makes ROM addresses not wrap around at 64 MB. looks like I'm wrong here, I just haven't seen a case of direct ROM execution yet I guess

mupen64plus/mupen64plus-core#997
https://benedani.xyz/files/mupen/readme.html
more information about this, not sure who the original author of the latter page is though

gee I wonder who it could be, if only there was something common in the url & the guy who made the issue or something

edit: in hindsight I could have made the above joke ^ in a less passive aggressive manner, apologies for that...

[m4xw]

On N64, code isn't ever executed from the ROM.

You can run code from uncached cart dom

[m4xw]

looks like I'm wrong here, I just haven't seen a case of direct ROM execution yet I guess

Well it is super slow because only uncached works and i think it only works in interpreter rn anyway..

Either way this PR should be aimed upstream I guess, I might allow it if they decline tho

I could add support for dynarec however..

Probably only some homebrew test roms even use that feature tho, data access is most common