mac: Set a valid interface number on hid_device_info for USB HID dev… #2
Conversation
Previously the interface would never be set on Mac. This presents a big pain because retrieving interface numbers can be the only way to distinguish between the interfaces returned by HIDAPI. This change makes it possible to retrieve interface number from an hid_device_info on Mac for USB HID devices only. It is unclear if the macOS IOKit library returns valid interface numbers for non-HID USB devices. Because of this, I have opted to simply skip that case - leave it initialised to `-1`. In the future, we can easily relax this restriction if it turns out IOKit correctly returns interface number with non-HID USB devices. For now, this commit brings 90% of the value at 5% of the risk.
z3ntu
changed the title
|
Thanks @todbot for merging this. However, can we use "rebase & merge" strategy to keep linear history? There are many advantages, the most important for me is possibility to |
A good start. Try also: @Qbicz I suggest also allowing |
|
@todbot yes, it's a good place. Basically, you apply your commits on top of the existing history and resolve any conflicts in your commit that introduces the change. I have changed settings to allow |
…ices
Previously the interface would never be set on Mac.
This presents a big pain because retrieving interface numbers can be the
only way to distinguish between the interfaces returned by HIDAPI.
This change makes it possible to retrieve interface number from an
hid_device_info on Mac for USB HID devices only.
It is unclear if the Mac OS IOKit library returns valid interface numbers for non-HID USB devices. Because of this, I have opted to simply skip that case - leave it initialised to
-1.In the future, we can easily relax this restriction if it turns out IOKit correctly returns interface number with non-HID USB devices. For now, this PR brings 90% of the value at 5% of the risk.
Re-open of signal11/hidapi#380