hidraw: only print errors when DEBUG_PRINTF is defined #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There're still |
|
This kernel version check is necessary for one workaround for kernels < 2.6.34. As this release is over 9 years old, we can probably remove that workaround now... And the |
|
Sure, why not - will you update it? |
|
@z3ntu please give your comment |
|
Yeah. Let's keep this PR on ice for now until #23 is ready and then adjust this one for hid_error function |
|
This is obsoleted by #23 now. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, the hidraw implementation prints messages to stderr, which the application using this library has no control over. This should be optional, just like it is in the libusb backend.
Originally signal11/hidapi#351